Date: Tue, 14 Apr 2015 14:58:52 -0700 From: hiren panchasara <hiren@strugglingcoder.info> To: Adrian Chadd <adrian@freebsd.org> Cc: Jack F Vogel <jfv@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>, erj@freebsd.org, Jack Vogel <jfvogel@gmail.com>, Jason Wolfe <nitroboost@gmail.com> Subject: Re: Full 32bit flowid from igb(4) Message-ID: <20150414215852.GC10620@strugglingcoder.info> In-Reply-To: <CAJ-Vmom5tetcq%2BJHFdYH6kWi8qx2GNEV7WAKfAb5%2B6D3YKr7OQ@mail.gmail.com> References: <20150330225945.GI10892@strugglingcoder.info> <CAJ-Vmom1tE6g=ta-DPLDF%2Bnp0GOpFYOXn=PkspaALfazz-n4Gg@mail.gmail.com> <20150331050628.GJ10892@strugglingcoder.info> <CAJ-VmokL1PnA=Nv0wKTWtY2f1RLCzW3GShOPQ0t=gd6B93kC4A@mail.gmail.com> <20150331170933.GK10892@strugglingcoder.info> <CAJ-Vmok19d4K0ucvsxc8kUmpv0e2L7CHkYjgNC56sg_wigC1cQ@mail.gmail.com> <20150403165411.GC72165@strugglingcoder.info> <CAJ-VmokzcHKHYanmwFgB_4d8CJKajs6G7gY11_J4nWGf3JAUkQ@mail.gmail.com> <20150403170239.GD72165@strugglingcoder.info> <CAJ-Vmom5tetcq%2BJHFdYH6kWi8qx2GNEV7WAKfAb5%2B6D3YKr7OQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--GZVR6ND4mMseVXL/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/03/15 at 12:15P, Adrian Chadd wrote: > On 3 April 2015 at 10:02, hiren panchasara <hiren@strugglingcoder.info> w= rote: > > On 04/03/15 at 10:00P, Adrian Chadd wrote: > >> On 3 April 2015 at 09:54, hiren panchasara <hiren@strugglingcoder.info= > wrote: > >> > On 03/31/15 at 11:15P, Adrian Chadd wrote: > >> >> Yeah, I think the right thing to do is: > >> >> > >> >> * If the descriptor says it's RSS, then use the flowid + rss type > >> > So, if we have multiqueue, we do everything needed to get RSS > >> > flowid/type. That means, with num_queues > 1 we can just expose thos= e. > >> > > >> >> * else, set it to queue id and set the type to opaque. > >> > > >> > This part becomes irrelevant as it's a single queue case. Do we care > >> > about setting flowid value/type in case of single queue? > >> > >> My whole point with not always setting it is that people may do things > >> to /other/ parts of the driver and suddenly the RSS field isn't the > >> RSS field anymore. > >> > >> Doubly so if you start playing with multiqueue + flowdirector on ixgbe= =2E :) > >> > >> So I'd rather the driver be right and correct - checking if the field > >> /is/ RSS and only setting the flowid+flowtype /if/ the value in that > >> register is an RSS flowid, rather than setting it to whatever's there > >> and hoping it's an RSS value. :) > > > > Okay, I guess it doesn't hurt to read those registers again at the time > > of actually assigning flowid/type. I'll do that and post a review on > > phabricator. >=20 > Well, the "Is this RSS flowid" bits are in the RX descriptor, so you > don't have to worry about reading registers. :) Adrian and I agreed on offline discussion that igb(4) drivers DTRT wrt having rss hash when we do multiqueue. I've added that one check and created this review for Jack/Eric: https://reviews.freebsd.org/D2296 Cheers, Hiren --GZVR6ND4mMseVXL/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVLY2bXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lm4cH/1uVDBaZ7eql8sOw+a7Pxu2d SnSsmwYX+x5blwj9/1gIbDNPh8N5tIc7D/GZFNqpElIE4lW2tv6MZQ1k4HfkstiB 7xVMnQkoZtSaptsAfpk5IdNeK/Hkwa0hLLqesgBt7sprrR5M6b1Grih+aLMtLHSR QAqrtVUfn3y46uATH6NcuPPGDKlh0LlWG1/NfbA99BdGZaL2Pq0FdhVjEVfoKfEO PnVoRRbOXkLtY3ebKSJk15+lMdwB61ucD8jDCjoGqxHq4UX0KHfFfVggEotnjOZS SAUaiWbZ+K6YBN2K5xbHitjIwU2CjswwN5Hxru9jYGtm/+fWlv6yKpng5FYQDv8= =Kq4H -----END PGP SIGNATURE----- --GZVR6ND4mMseVXL/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150414215852.GC10620>