Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 May 2005 02:10:58 +0900
From:      Alexander Nedotsukov <bland@FreeBSD.org>
To:        Alexander Nedotsukov <bland@FreeBSD.org>
Cc:        des@FreeBSD.org
Subject:   Re: nfsclient broken?
Message-ID:  <428A25A2.4020206@FreeBSD.org>
In-Reply-To: <428A1AE0.1020407@FreeBSD.org>
References:  <428A1AE0.1020407@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------030108020302080306090305
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit

Here is what I think was actually implied.
Alexander Nedotsukov wrote:

> Hi, FYI; Just complete full 6-CURRENT update. Now all nfs mounts (used 
> to be rw) stays read-only.
>
> /sys/nfsclient/nfs_vfsops.c:
>     $FreeBSD: src/sys/nfsclient/nfs_vfsops.c,v 1.175 2005/05/17 
> 12:00:43 des Exp $
>
> BTW. Commit log do not match actual change.
>
> Alexander.
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to 
> "freebsd-current-unsubscribe@freebsd.org"



--------------030108020302080306090305
Content-Type: text/x-patch;
 name="nfs_vfsops.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="nfs_vfsops.c.diff"

Index: nfs_vfsops.c
===================================================================
RCS file: /home/ncvs/src/sys/nfsclient/nfs_vfsops.c,v
retrieving revision 1.175
diff -u -r1.175 nfs_vfsops.c
--- nfs_vfsops.c	17 May 2005 12:00:43 -0000	1.175
+++ nfs_vfsops.c	17 May 2005 16:53:30 -0000
@@ -519,9 +519,9 @@
 	 * flag is already clear, or this is a root mount and it was set
 	 * intentionally at some previous point.
 	 */
-	if (vfs_getopt(mp->mnt_optnew, "ro", NULL, NULL) != 0)
+	if (vfs_getopt(mp->mnt_optnew, "ro", NULL, NULL) == 0)
 		mp->mnt_flag |= MNT_RDONLY;
-	else if (!(mp->mnt_flag & MNT_UPDATE))
+	else if (mp->mnt_flag & MNT_UPDATE)
 		mp->mnt_flag &= ~MNT_RDONLY;
 
 	/*

--------------030108020302080306090305--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?428A25A2.4020206>