Date: Mon, 24 Jun 2013 08:19:18 -0400 From: Ryan Steinmetz <zi@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r321677 - in head/security/duo: . files Message-ID: <20130624121917.GA85793@exodus.zi0r.com> In-Reply-To: <20130624120316.GB79369@FreeBSD.org> References: <201306241155.r5OBtgQj057667@svn.freebsd.org> <20130624120316.GB79369@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On (06/24/13 12:03), Alexey Dokuchaev wrote: >On Mon, Jun 24, 2013 at 11:55:42AM +0000, Ryan Steinmetz wrote: >> New Revision: 321677 >> URL: http://svnweb.freebsd.org/changeset/ports/321677 >> >> +.if ${OSVERSION} >= 1000000 >> +USE_GCC= yes >> +.endif > >Presuming it's due to Clang... > Correct. >Two quick questions: 1) why not just say USE_GCC=any; and 2) how hard would >it be to fix Clang fallouts, and remove any explicit compiler requirement? > I was not aware that USE_GCC=any would do this. However, I'm going to leave the port as-is for now, simply to avoid repo churn. I expect the clang fixes to make it into the next release shortly, and the workaround will be removed at that time. The proposed changes were submitted by brooks@ upstream for review/inclusion in the next release of duo. >Note that =yes implies GCC 4.6+ or something, yet on OSVERSION < 1000000 >apparently our default system 4.2 is enough. > >> @${CAT} ${PKGMESSAGE} > >It would be nice if cat(1) had been surrounded with ${ECHO_MSG}'s to ensure >consistent padding when installing from package vs. ports. If any padding >is present in the pkg-message file itself, it should be removed. This might be a good idea for inclusion in bsd.port.mk. I believe that the current 'norm' is to simply cat pkg-message. > >./danfe -- Ryan Steinmetz PGP: EF36 D45A 5CA9 28B1 A550 18CD A43C D111 7AD7 FAF2
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130624121917.GA85793>