Date: Thu, 13 Sep 2001 01:07:33 +0000 From: Tony Finch <dot@dotat.at> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/30543: [PATCH] use err() instead of just exit() when `install` fails Message-ID: <E15hKyb-0001f4-00@hand.dotat.at>
next in thread | raw e-mail | index | archive | help
>Number: 30543 >Category: bin >Synopsis: [PATCH] use err() instead of just exit() when `install` fails >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 12 17:10:00 PDT 2001 >Closed-Date: >Last-Modified: >Originator: Tony Finch >Release: FreeBSD 4.4-RC i386 >Organization: dotat labs >Environment: System: FreeBSD hand.dotat.at 4.4-RC FreeBSD 4.4-RC #4: Sat Sep 1 19:06:27 GMT 2001 fanf@hand.dotat.at:/FreeBSD/obj/FreeBSD/releng4/sys/SHARP i386 >Description: In some circumstances, `install` can fail mysteriously when trying to run `strip` in a subprocess. >How-To-Repeat: Sorry, I can't remember what triggered this one. >Fix: Index: usr.bin/xinstall//xinstall.c =================================================================== RCS file: /home/ncvs/src/usr.bin/xinstall/xinstall.c,v retrieving revision 1.38.2.3 diff -u -r1.38.2.3 xinstall.c --- usr.bin/xinstall//xinstall.c 2001/08/01 06:48:41 1.38.2.3 +++ usr.bin/xinstall//xinstall.c 2001/08/28 22:24:27 @@ -713,7 +713,7 @@ default: if (wait(&status) == -1 || status) { (void)unlink(to_name); - exit(EX_SOFTWARE); + err(EX_SOFTWARE, "wait"); /* NOTREACHED */ } } >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E15hKyb-0001f4-00>