Date: Sat, 23 Nov 2002 12:50:57 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Nate Lawson <nate@root.org> Cc: Brooks Davis <brooks@one-eyed-alien.net>, hackers@FreeBSD.ORG Subject: Re: [brooks@one-eyed-alien.net: [PATCH] switching to if_xname] Message-ID: <20021123125056.A10727@Odin.AC.HMC.Edu> In-Reply-To: <Pine.BSF.4.21.0211191412280.61484-100000@root.org>; from nate@root.org on Tue, Nov 19, 2002 at 02:15:34PM -0800 References: <20021119125107.A16432@Odin.AC.HMC.Edu> <Pine.BSF.4.21.0211191412280.61484-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 19, 2002 at 02:15:34PM -0800, Nate Lawson wrote: > On Tue, 19 Nov 2002, Brooks Davis wrote: > > On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote: > > > I'm trying to get some review for the following patch. I realize it's > > > quite large, but most it is is trivial. The ipfw code is the only th= ing > > > that worries me significantly. I have promised Kris that I will fix > > > ports that break with this change so you don't need to worry about th= at > > > issue. > >=20 > > I've uploaded a new version of the patch addressing the concerns I've > > heard to: > >=20 > > http://people.freebsd.org/~brooks/patches/if_xname.diff >=20 > Thanks for fixing things. Are all the uses of sprintf() below safe and > intentional? No, they weren't intentional. I managed to forget to scan for those. Most of them were safe, but I've removed all of them. (Grep still hits a few due to ipf using sprintf). I've uploaded a new version. I'm now testing a world build on panther. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE93+owXY6L6fI4GtQRAsVgAJsEZKMnJ2w0MJYosoAVKATT/s0iKACg4KSa Ow+CxWm628StUEhDTPMF5H8= =hrle -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021123125056.A10727>