Date: Wed, 16 Aug 2006 20:05:14 +0200 From: =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= <gabor@FreeBSD.org> To: ports@FreeBSD.org Cc: portmgr@FreeBSD.org, Erwin Lansing <erwin@FreeBSD.org>, Kris Kennaway <kris@obsecurity.org> Subject: HEADS-UP: [Fwd: Re: Future plans for DESTDIR] Message-ID: <44E35E5A.1090306@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------020003050302050204080800 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi folks, sometimes good ideas come later, so please wait a bit with making your ports DESTDIR-aware. Kris had a very interesting suggestion. I wonder how we haven't thought of this so far. This needs a bit more of discussion, though, but if we can work this out a bit better, things will become very easy. Comments are welcome. -- Cheers, Gabor --------------020003050302050204080800 Content-Type: message/rfc822; name="Re: Future plans for DESTDIR" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Re: Future plans for DESTDIR" Return-Path: <gabor.kovesdan+caf_=gabor=t-hosting.hu@gmail.com> X-Original-To: gabor@t-hosting.hu Delivered-To: gabor@t-hosting.hu Received: from localhost (localhost [127.0.0.1]) by server.t-hosting.hu (Postfix) with ESMTP id 8124899C855 for <gabor@t-hosting.hu>; Wed, 16 Aug 2006 18:44:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.t-hosting.hu ([127.0.0.1]) by localhost (server.t-hosting.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fZH4uaUdT62X for <gabor@t-hosting.hu>; Wed, 16 Aug 2006 18:44:08 +0200 (CEST) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.185]) by server.t-hosting.hu (Postfix) with ESMTP id 0DAB199C853 for <gabor@t-hosting.hu>; Wed, 16 Aug 2006 18:44:06 +0200 (CEST) Received: by nf-out-0910.google.com with SMTP id k26so792476nfc for <gabor@t-hosting.hu>; Wed, 16 Aug 2006 09:43:59 -0700 (PDT) Received: by 10.48.220.15 with SMTP id s15mr945894nfg; Wed, 16 Aug 2006 09:43:59 -0700 (PDT) X-Forwarded-To: gabor@t-hosting.hu X-Forwarded-For: gabor.kovesdan@gmail.com gabor@t-hosting.hu X-Gmail-Received: ee9380c43c96b84085afdd48b814e989d40fdeba Delivered-To: gabor.kovesdan@gmail.com Received: by 10.49.32.17 with SMTP id k17cs93353nfj; Wed, 16 Aug 2006 09:43:57 -0700 (PDT) Received: by 10.35.20.14 with SMTP id x14mr1764946pyi; Wed, 16 Aug 2006 09:43:57 -0700 (PDT) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by mx.gmail.com with ESMTP id 37si703295nzf.2006.08.16.09.43.56; Wed, 16 Aug 2006 09:43:57 -0700 (PDT) Received-SPF: neutral (gmail.com: 216.136.204.119 is neither permitted nor denied by best guess record for domain of kris@obsecurity.org) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 823D7726B7 for <gabor.kovesdan@gmail.com>; Wed, 16 Aug 2006 16:43:37 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: by hub.freebsd.org (Postfix) id 75EB216A4DF; Wed, 16 Aug 2006 16:43:37 +0000 (UTC) Delivered-To: gabor@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7461416A4DE; Wed, 16 Aug 2006 16:43:37 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE5FE43D76; Wed, 16 Aug 2006 16:42:48 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 204351A3C1E; Wed, 16 Aug 2006 09:42:40 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 74DC75203D; Wed, 16 Aug 2006 12:42:39 -0400 (EDT) Date: Wed, 16 Aug 2006 12:42:39 -0400 From: Kris Kennaway <kris@obsecurity.org> To: G?bor K?vesd?n <gabor@FreeBSD.org>, portmgr@FreeBSD.org Subject: Re: Future plans for DESTDIR Message-ID: <20060816164239.GA10619@xor.obsecurity.org> References: <44E236BC.7020207@FreeBSD.org> <20060816163035.GU80138@droso.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <20060816163035.GU80138@droso.net> User-Agent: Mutt/1.4.2.2i --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 16, 2006 at 06:30:35PM +0200, Erwin Lansing wrote: > On Tue, Aug 15, 2006 at 11:03:56PM +0200, G?bor K?vesd?n wrote: > > Hi Erwin, >=20 > Hi, > >=20 > > I tried to talk to you on irc, but you seemed to be quite busy today.= =20 > > Unfortunately, some people are unsatisfied and disappointed with my=20 > > DESTDIR implementation. I don't know what to do now, since I just did= =20 > > what we discussed to avoid big changes all over the ports tree. A guy= =20 > > complained that LOCALBASE, LINUXBASE and X11BASE should be reverted, bu= t=20 > > we discussed it is wrong, because we had to change *_DEPENDS all over= =20 >=20 > Right. The idea here was to get DESTDIR added without having to change a > huge number of ports. Somehow the PREFIX problem got overlooked. >=20 > > the ports tree. That definitely should not happen. Andrew (infofarmer@)= =20 > > suggested to change PREFIX to fully qualified so that we don't need to= =20 > > do s/PREFIX/TARGETDIR/ and introduce PREFIX_REL for sed substitutions.= =20 > > With this we could also keep TARGETDIR for compatibility, but I should= =20 > > now how portmgr feels about this before I start to work on this.=20 > > Andrew's way seems to be reasonable for me. It changes the=20 > > interpretation of PREFIX, but this change won't violate POLA, I can=20 > > workaround that with a hackery, and according to Andrew, we would get= =20 > > many of the ports DESTDIR aware without much pain. > >=20 > This would fix the install time location, without having to change all > port install targets. It does significantly change the behaviour of > PREFIX though, which is assumed to be under DESTDIR (see > /usr/share/mk/), so it's hard to see all the consequences beforehand and > it would be good to see an implementation first. I think that would also produce a lot of hidden landmines, because PREFIX is hard-coded into many binaries for referring to the location of installed files at runtime. So is LOCALBASE et al, which is why none of them can have DESTDIR prepended automatically. The only simple solution I can think of (which doesn't involve modifying thousands of ports one way or another) is the mount_nullfs+chroot method I mentioned previously. > Also, keeping TARGETDIR should only be a temporary measure until those > ports that have been changed are changed back. You probably should tell > people on ports@ that you're working on this issue and that we do not > want to see any more TARGETDIR changes committed until we find the best > way forward. Kris --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE40r/Wry0BWjoQKURArkfAJ430RDzKm8hZ0IRQ2qvtWgXnJonkACg22Kl bPjw+YnWvn30YWhg1iGeSZw= =snY1 -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7-- --------------020003050302050204080800--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44E35E5A.1090306>