Date: Mon, 30 Jun 2014 18:44:41 +0200 From: Hans Petter Selasky <hps@selasky.org> To: John Baldwin <jhb@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Mateusz Guzik <mjguzik@gmail.com>, Ed Maste <emaste@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r267961 - in head/sys: amd64/acpica amd64/amd64 amd64/pci amd64/vmm arm/arm arm/freescale/imx arm/xscale/ixp425 cam cam/ata cam/ctl cam/scsi cddl/compat/opensolaris/kern cddl/contrib/op... Message-ID: <53B193F9.9070903@selasky.org> In-Reply-To: <201406301143.26218.jhb@freebsd.org> References: <201406271633.s5RGXih6076565@svn.freebsd.org> <53AE3E42.7050606@selasky.org> <53AED837.8050702@selasky.org> <201406301143.26218.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/30/14 17:43, John Baldwin wrote: > On Saturday, June 28, 2014 10:59:03 am Hans Petter Selasky wrote: >> FYI: >> >> Possibly the sysctl patches will not get MFCed, and be a FreeBSD-11 and >> onwards only feature, even though the commit message states MFC after xxx. > > I suspect that that is probably for the best. Also, it would have been better > to split out the other changes (like fixing mismatched tunables, etc.) into a > separate commit from the CTLFLAG_TUN change. That makes reviewing them > easier, and it also means you could more easily MFC just those fixes without > pulling in the larger change. > Hi, Right. BTW: powerpc64 is failing due to my changes. I looks like a GCC issue, that it does not allow "static" and "extern" entries to reside in the same section. A simple way to solve this is by using a double pointer, so that the type of the exported section data is always "static" declared. Then GCC won't complain any more. Any comments about how to resolve this? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53B193F9.9070903>