Date: Sat, 07 Jul 2007 17:18:35 -0400 From: Tom McLaughlin <tmclaugh@FreeBSD.org> To: Rene Ladan <r.c.ladan@gmail.com> Cc: x11@FreeBSD.org Subject: Re: [Fwd: sysutils/libchk: Ignore locations under /usr/X11R6] Message-ID: <1183843115.39443.4.camel@localhost> In-Reply-To: <468FEC03.9010808@gmail.com> References: <468FEC03.9010808@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-/30lhzdwH8NEe7zphvHK
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sat, 2007-07-07 at 21:39 +0200, Rene Ladan wrote:=20
> Hi,
>=20
> This request to skip $X11BASE in the sysutils/libchk port is similar to=20
> ports/113099
>=20
> Is it ok / politically correct to approve it?
>=20
> Regards,
> Rene
>=20
The last patch in PR 113099 doesn't prevent descending into /usr/local
twice when /usr/X11R6 is a symlink to it which is why I sent my PR. My
patch unfortunately breaks when /usr/X11R6 actually exists and doesn't
even allow you to add it as an extra path on the commandline. I would
go with whatever Akinori feels is best which looks like checking the
realpath of X11BASE. I don't know ruby so...
tom
> -------- Originele bericht --------
> Onderwerp: sysutils/libchk: Ignore locations under /usr/X11R6
> Datum: Wed, 4 Jul 2007 21:28:38 -0400
> Van: Tom McLaughlin <tmclaugh@FreeBSD.org>
> Aan: FreeBSD gnats submit <FreeBSD-gnats-submit@FreeBSD.org>
> CC: r.c.ladan@gmail.com
>=20
>=20
> >Submitter-Id: current-users=20
> >Originator: Tom McLaughlin=20
> >Organization: =20
> >Confidential: no=20
> >Synopsis: sysutils/libchk: Ignore locations under /usr/X11R6=20
> >Severity: non-critical=20
> >Priority: low=20
> >Category: ports=20
> >Class: change-request=20
> >Release: FreeBSD 6.2-STABLE i386=20
> >Environment:
>=20
>=20
> System: FreeBSD 6.2-STABLE #0: Tue Jun 19 03:46:08 EDT 2007
> tom@bofh:/usr/obj/usr/src/sys/GENERIC_ULE
>=20
>=20
>=20
> >Description:
>=20
>=20
> Attached patch causes libchk to ignore the following directories=20
> automatically since
> they are really locations under /usr/local now.
>=20
> /usr/X11R6/bin
> /usr/X11R6/lib
> /usr/X11R6/libexec
> /usr/X11R6/sbin
>=20
> Man page is also updated.
>=20
>=20
> >How-To-Repeat:
>=20
>=20
>=20
>=20
>=20
> >Fix:
>=20
>=20
> --- patch-libchk.rb begins here ---
> --- libchk.rb.orig Fri May 14 13:11:09 2004
> +++ libchk.rb Wed Jul 4 19:32:11 2007
> @@ -60,7 +60,12 @@
> "#{$x11base}/sbin",
> ]
>=20
> - $exclude_dirs =3D []
> + $exclude_dirs =3D [
> + "#{$x11base}/bin",
> + "#{$x11base}/lib",
> + "#{$x11base}/libexec",
> + "#{$x11base}/sbin",
> + ]
> end
>=20
> def main(argv)
> --- patch-libchk.rb ends here ---
> --- patch-libchk.1 begins here ---
> --- libchk.1.orig Sun May 2 14:56:10 2004
> +++ libchk.1 Wed Jul 4 19:17:13 2007
> @@ -37,9 +37,6 @@
> .It Pa $LOCALBASE/bin
> .It Pa $LOCALBASE/libexec
> .It Pa $LOCALBASE/sbin
> -.It Pa $X11BASE/bin
> -.It Pa $X11BASE/libexec
> -.It Pa $X11BASE/sbin
> .El
> .Pp
> And the directories listed in
> @@ -123,9 +120,6 @@
> .It Ev LOCALBASE
> The local base directory. (default:
> .Pa /usr/local )
> -.It Ev X11BASE
> -The X11 base directory. (default:
> -.Pa /usr/X11R6 )
> .El
> .Sh SEE ALSO
> .Xr ldconfig 8
> --- patch-libchk.1 ends here ---
>=20
>=20
>=20
>=20
>=20
--=-/30lhzdwH8NEe7zphvHK
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQBGkAMl4zniJeL3s9gRAv5EAKCC5AMenyRN4ieS3h9pJdLKeqQfXQCgrEWX
AyYxC1h+Sx7JTtd4l1KIS+k=
=L1VK
-----END PGP SIGNATURE-----
--=-/30lhzdwH8NEe7zphvHK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1183843115.39443.4.camel>