Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Mar 2009 02:32:37 +0000 (UTC)
From:      Sean Farley <scf@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r189907 - head/sys/net
Message-ID:  <200903170232.n2H2Wboh078613@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: scf
Date: Tue Mar 17 02:32:36 2009
New Revision: 189907
URL: http://svn.freebsd.org/changeset/base/189907

Log:
  Remove the splimp()/splx() calls around the setting of the MTU.  They are
  no-op's that I inadvertently added.  Even if locking is needed in general
  for the ioctl's, setting a single long will not need it due to the operation
  being atomic.
  
  Reported by:	rwatson

Modified:
  head/sys/net/if_tap.c

Modified: head/sys/net/if_tap.c
==============================================================================
--- head/sys/net/if_tap.c	Tue Mar 17 01:46:40 2009	(r189906)
+++ head/sys/net/if_tap.c	Tue Mar 17 02:32:36 2009	(r189907)
@@ -611,9 +611,7 @@ tapifioctl(struct ifnet *ifp, u_long cmd
 			break;
 
 		case SIOCSIFMTU:
-			s = splimp();
 			ifp->if_mtu = ifr->ifr_mtu;
-			splx(s);
 			break;
 
 		case SIOCGIFSTATUS:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903170232.n2H2Wboh078613>