Date: Tue, 25 Jan 2000 21:00:07 +0900 From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: dfr@nlsystems.com Cc: imp@village.org, n_hibma@webweaving.org, current@freebsd.org Subject: Re: APM still ignoring DEVICE_SUSPEND errors Message-ID: <200001251200.VAA24572@tasogare.imasy.or.jp> In-Reply-To: Your message of "Tue, 25 Jan 2000 09:17:05 %2B0000 (GMT)" <Pine.BSF.4.10.10001250916120.25770-100000@salmon.nlsystems.com> References: <Pine.BSF.4.10.10001250916120.25770-100000@salmon.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, 24 Jan 2000, Warner Losh wrote:
>
> > In message <Pine.BSF.4.20.0001231408180.4623-200000@localhost> Nick Hibma writes:
> > : The following patch fixes two things: First, DEVICE_SUSPEND errors are
> > : no longer ignored. Since we have defaults for methods we should no
> > : longer ignore these errors. Also, DEVICE_RESUME wasn't done when the
> > : apm_suspend_system event failed.
> >
> > I had similar patches that workede several months ago, but they have
> > since been lost.
> >
> > : Second, in the ordering of DEVICE_* and apm_hook_* is not symmetric for
> > : suspend and resume. The patch reverses the resume case as well to be
> > :
> > : apm_hook_resume(...)
> > : DEVICE_RESUME(root)
> > :
> > : Send me some feedback on this. I've mailed the people mentioned in the
> > : head of the file, but so far got no response. I would like to make sure
> > : we get this right when USB devices are used. Some of them don't suspend
> > : and the suspend should be refused in that case.
> >
> > Any reason to not shoot the apm_hook_{suspend,resume} in the head and
> > just use newbus suspend/resume everywhere?
>
> Are there any non-newbus devices which need suspend/resume? I think the
> i386 clock uses the apm hooks but I might be misremembering.
No, it just reloads the countdown register of i8254 in
apm_default_resume() for now. But once the PIT become an ordinary
device like any other, this is planned to be the device's resume
method.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001251200.VAA24572>