Date: Fri, 22 Nov 2002 09:18:50 -0800 From: Luigi Rizzo <rizzo@icir.org> To: John Polstra <jdp@polstra.com> Cc: net@FreeBSD.ORG, sam@errno.com Subject: Re: CFR: MFC of mtags Message-ID: <20021122091850.A81622@xorpc.icir.org> In-Reply-To: <200211221645.gAMGjKPH082267@vashon.polstra.com>; from jdp@polstra.com on Fri, Nov 22, 2002 at 08:45:20AM -0800 References: <196301c291e9$56d25e70$52557f42@errno.com> <200211221645.gAMGjKPH082267@vashon.polstra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
i am pretty sure that this change does not affect low level drivers; the "any software that uses them" comment almost surely refers to the m_aux field, not to the entire struct mbuf. This said, fair behaviour cannot be requested to one side only. Sam posted patches, so those who have the hw/sw for which they suspect incompatibilities have all the resources to try the new code and find out whether their suspicions are founded or not. I am surely willing to listen to objections based on convincing evidence of breakage, whereas pure speculation is a much weaker argument. cheers luigi On Fri, Nov 22, 2002 at 08:45:20AM -0800, John Polstra wrote: > In article <196301c291e9$56d25e70$52557f42@errno.com>, Sam Leffler > <sam@errno.com> wrote: > > I want to commit the mbuf packet tag changes to stable. These > > changes replace the aux mbuf pointer in the mbuf with a list of > > "packet tags". This does not change the size of the mbuf structure > > but does affect any software that uses them (presently only KAME > > ipsec which has been patched to use packet tags instead). > > I would strongly prefer that you not put this into the 4.x branch. > The project has a policy against incompatible ABI changes within the > -stable branch. If you do this MFC then those of us who rely on > third-party binary-only network drivers (such as the ET Inc. drivers, > upon which I and many others rely for network connectivity) will be > SOL. Changing the ABI within the branch is unfair to the vendors who > try to maintain drivers for FreeBSD, and it only discourages them from > trying to support our operating system. Let's just let the 4.x branch > live out the rest of its life span in a compatible way. > > John > -- > John Polstra > John D. Polstra & Co., Inc. Seattle, Washington USA > "Disappointment is a good sign of basic intelligence." -- Chögyam Trungpa > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021122091850.A81622>