Date: Sat, 6 Apr 2002 15:32:32 -0800 From: Murray Stokely <murray@FreeBSD.org> To: "Bruce A. Mah" <bmah@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 8929 for review Message-ID: <20020406233232.GR5732@freebsdmall.com> In-Reply-To: <200204022153.g32LrnQ29689@freefall.freebsd.org> References: <200204022153.g32LrnQ29689@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think this should be made in CVS, possibly with 1 line comment summarizing the rationale. - Murray On Tue, Apr 02, 2002 at 01:53:49PM -0800, Bruce A. Mah wrote: > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8929 > > Change 8929 by bmah@bmah_intruder on 2002/04/02 13:52:50 > > Don't make the assumption that source files are writable. > The FDP infrastructure has a few constructs of the form > "cp foo bar; cat baz >> bar". This breaks if foo isn't > writable (as is frequently the case in P4 work directory). > > I'm not sure if this change should be made in CVS or not, > and if so, if this is exactly the right change. In the meantime, > we've at least unbroken doc builds out of P4 work areas. > > Affected files ... > > ... //depot/releng/5_dp1/doc/share/mk/doc.docbook.mk#2 edit > > Differences ... > > ==== //depot/releng/5_dp1/doc/share/mk/doc.docbook.mk#2 (text+ko) ==== > > @@ -413,7 +413,8 @@ > ${LN} -f ${.ALLSRC} ${.TARGET} > > ${DOC}.tex-pdf: ${SRCS} ${IMAGES_PDF} ${INDEX_SGML} ${PRINT_INDEX} > - ${CP} -p ${PDFTEX_DEF} ${.TARGET} > + ${RM} -f ${.TARGET} > + ${CAT} ${PDFTEX_DEF} > ${.TARGET} > ${JADE} -V tex-backend ${PRINTOPTS} -ioutput.print.pdf \ > ${JADEOPTS} -t tex -o /dev/stdout ${MASTERDOC} >> ${.TARGET} > > @@ -726,7 +727,8 @@ > > .if ${LOCAL_CSS_SHEET} != ${CSS_SHEET} > ${LOCAL_CSS_SHEET}: ${CSS_SHEET} > - ${CP} -p ${.ALLSRC} ${.TARGET} > + ${RM} -f ${.TARGET} > + ${CAT} ${.ALLSRC} > ${.TARGET} > .if defined(CSS_SHEET_ADDITIONS) > ${CAT} ${.CURDIR}/${CSS_SHEET_ADDITIONS} >> ${.TARGET} > .endif To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-releng" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020406233232.GR5732>