Date: Wed, 24 Apr 2002 21:14:20 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 10204 for review Message-ID: <Pine.NEB.3.96L.1020424211310.55944L-100000@fledge.watson.org> In-Reply-To: <200204241418.g3OEIIR33520@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 24 Apr 2002, Brian F. Feldman wrote: > Robert Watson <rwatson@FreeBSD.org> wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=10204 > > > > Change 10204 by rwatson@rwatson_tislabs on 2002/04/23 20:13:49 > > > > Work around existing FreeBSD VFS locking breakage: don't assert > > that vp is locked for mac_cred_check_search_vnode(), because > > apparently it's not. Existing assertions in lookup() already > > catch this same bug, so it's not our fault (and needs to be > > fixed). > > Are you sure ASSERT_VOP_LOCKED() works like you'd expect for shared > locks, too? Not entirely sure, and should check. Interestingly, disabling my assert still results in a panic early in init due to existing adjacent assertions in lookup(). I'm busy unwinding lookup behavior to try and get a grasp of what's going on. I realize VFS locking is a deep pit, but having a few more assertions working would be helpful for debugging this stuff. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1020424211310.55944L-100000>