Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Feb 2016 01:11:51 +0000 (UTC)
From:      Eric Joyner <erj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r295947 - head/sys/dev/ixl
Message-ID:  <201602240111.u1O1BptU006411@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: erj
Date: Wed Feb 24 01:11:51 2016
New Revision: 295947
URL: https://svnweb.freebsd.org/changeset/base/295947

Log:
  ixl(4)/ixlv(4): Remove a couple unnecessary register writes/flushes.
  
  The one in ixl_xmit() has brought up to us as being unnecessary at least a
  couple times.
  
  Differential Revision:	https://reviews.freebsd.org/D5208
  Tested by:	jeffrey.e.pieper@intel.com
  Sponsored by:	Intel Corporation

Modified:
  head/sys/dev/ixl/if_ixl.c
  head/sys/dev/ixl/ixl_txrx.c

Modified: head/sys/dev/ixl/if_ixl.c
==============================================================================
--- head/sys/dev/ixl/if_ixl.c	Wed Feb 24 00:42:43 2016	(r295946)
+++ head/sys/dev/ixl/if_ixl.c	Wed Feb 24 01:11:51 2016	(r295947)
@@ -2912,7 +2912,6 @@ ixl_initialize_vsi(struct ixl_vsi *vsi)
 			device_printf(dev, "Fail in init_rx_ring %d\n", i);
 			break;
 		}
-		wr32(vsi->hw, I40E_QRX_TAIL(que->me), 0);
 #ifdef DEV_NETMAP
 		/* preserve queue */
 		if (vsi->ifp->if_capenable & IFCAP_NETMAP) {

Modified: head/sys/dev/ixl/ixl_txrx.c
==============================================================================
--- head/sys/dev/ixl/ixl_txrx.c	Wed Feb 24 00:42:43 2016	(r295946)
+++ head/sys/dev/ixl/ixl_txrx.c	Wed Feb 24 01:11:51 2016	(r295947)
@@ -390,7 +390,6 @@ ixl_xmit(struct ixl_queue *que, struct m
 	++txr->total_packets;
 	wr32(hw, txr->tail, i);
 
-	ixl_flush(hw);
 	/* Mark outstanding work */
 	if (que->busy == 0)
 		que->busy = 1;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602240111.u1O1BptU006411>