Date: Thu, 24 Jul 2008 13:42:30 -0300 From: Marcelo Araujo <araujobsdport@gmail.com> To: Jeremy Messenger <mezz7@cox.net> Cc: Olafur Osvaldsson <osvaldsson@icelandic.net>, ports@freebsd.org, "Philip M. Gollucci" <pgollucci@p6m7g8.com>, pgollucci@freebsd.org, Ion-Mihai Tetcu <itetcu@freebsd.org>, Florent Thoumie <flz@xbsd.org> Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes Message-ID: <20080724164230.GD1170@ponderosa.intelbras.com.br> In-Reply-To: <op.uerfmj0w9aq2h7@mezz.mezzweb.com> References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> <a01628140807230314r247cd0b2h5da1138ca0a5b67@mail.gmail.com> <F6E63544-13DD-4464-8EA5-C6D977176A0E@icelandic.net> <a01628140807230508g340aac64x78eeeb8e9a637079@mail.gmail.com> <20080723151212.18dfb88d@it.buh.tecnik93.com> <a01628140807230806v1706061aqd15d5825d6dbbb1@mail.gmail.com> <48874AB6.6080604@p6m7g8.com> <op.uerfmj0w9aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--qGV0fN9tzfkG3CxV Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 23, 2008 at 02:40:57PM -0500, Jeremy Messenger wrote: > On Wed, 23 Jul 2008 10:13:58 -0500, Philip M. Gollucci=20 > <pgollucci@p6m7g8.com> wrote: >=20 >> Florent Thoumie wrote: >>> On Wed, Jul 23, 2008 at 1:12 PM, Ion-Mihai Tetcu <itetcu@freebsd.org>= =20 >>> wrote: >>>> On Wed, 23 Jul 2008 13:08:03 +0100 >>>> "Florent Thoumie" <flz@xbsd.org> wrote: >>>>=20 >>>>> On Wed, Jul 23, 2008 at 12:30 PM, Olafur Osvaldsson >>>>> <osvaldsson@icelandic.net> wrote: >>>>>> This is something the PR responsible introduced in his original >>>>>> patch... >>>>> It's still present in your version. Anyway, I'm not blaming anyone, >>>>> just pointing out what I think is a mistake. >>>> So this is not for the user but for the port? >>>>=20 >>>> I'll do a swap on the tree for it, because I'm sure there are more >>>> ports doing something like: >>>> .ifndef(NO_INSTALL_MANPAGES) >>>> ...... >>>> .endif >> I was talking to itectu@ about this, and figured it would be better in= =20 >> Mk/bsd.port.mk. >>=20 >>=20 >>> The general rule of thumb is: if it doesn't begin with WITH_ or >>> WITHOUT_, it's not user-settable. NO_INSTALL_MANPAGES is used for >>> ports using imake that don't understand the install.man target. >> /me thought that was the USE_ vs WITH(OUT)?_ difference. >>=20 >> NO* is supposed to be user settable right ? >=20 > While I am here, have you gotten my email about scons? >=20 > http://lists.freebsd.org/pipermail/cvs-ports/2008-July/153324.html >=20 > ---------------------------------------------- > # pkg_info -IX scons > scons-0.98.5 A build tool alternative to make > # ls /usr/local/man/man1/ | grep scons > scons-time.1.gz > scons.1.gz > sconsign.1.gz > # pkg_delete -f scons-0.98.5 > # ls /usr/local/man/man1/ | grep scons > [...empty...] > # cd /usr/ports/devel/scons > # grep NO Makefile > .if !defined (NO_INSTALL_MANPAGES) > # make NO_INSTALL_MANPAGES=3Dyes install > [...] > Installed SCons scripts into /usr/local/bin > Installed SCons man pages into /usr/local/man/man1 > =3D=3D=3D> Registering installation for scons-0.98.5 > # ls /usr/local/man/man1/ | grep scons > scons-time.1 > scons.1 > sconsign.1 > # pkg_delete -f scons-0.98.5 > # ls /usr/local/man/man1/ | grep scons > scons-time.1 > scons.1 > sconsign.1 > ---------------------------------------------- >=20 > The scons plist is broke with NO_INSTALL_MANPAGES. >=20 > Cheers, > Mezz >=20 >>> Now of course there are exceptions (usually for no good reason IMHO). >>> The likes of NOPORTDOCS/NOPORTEXAMPLES/... could be changed to >>> WITHOUT_DOCS/WITHOUT_EXAMPLES, it's just waiting for somebody to do >>> the work. >> Heh, maybe, I kind of feel like it will get reject as a style(9) change. >>=20 >> I'm all for it though, not saying I'm going to do it though. >=20 >=20 Hi Jeremy, I'll check it tonight. Thanks. --=20 Marcelo Araujo araujo@FreeBSD.org http://www.FreeBSD.org Keep emotionally active, cater to your favorite neurosis. --qGV0fN9tzfkG3CxV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIiLD2ovxJd1Pkz6gRAp8kAJ9aI/RoWbizw3qNt6CCGQk6tgvkWwCeNy9y BVcNjkDjxvIxElAljBRubjI= =Jolu -----END PGP SIGNATURE----- --qGV0fN9tzfkG3CxV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080724164230.GD1170>