Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Sep 2016 13:55:54 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Oleksandr Tymoshenko <gonzo@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r306355 - in head/sys: dev/atkbdc sys
Message-ID:  <3815150.rnkVxtqPiv@ralph.baldwin.cx>
In-Reply-To: <201609262206.u8QM6J5q070986@repo.freebsd.org>
References:  <201609262206.u8QM6J5q070986@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, September 26, 2016 10:06:19 PM Oleksandr Tymoshenko wrote:
> Author: gonzo
> Date: Mon Sep 26 22:06:19 2016
> New Revision: 306355
> URL: https://svnweb.freebsd.org/changeset/base/306355
> 
> Log:
>   Add Elantech trackpad support
>   
>   Elantech trackpads are found in some laptops like the Asus UX31E. They
>   are "synaptics compatible" but use a slightly different protocol.
>   
>   Elantech hardware support is not enabled by default and just like
>   Synaptic or TrackPoint devices it should be enabled by setting
>   tunable, in this case hw.psm.elantech_support, to non-zero value
>   
>   PR:		205690
>   Submitted by:	Vladimir Kondratyev <wulf@cicgroup.ru>
>   MFC after:	1 week
>
> Modified: head/sys/dev/atkbdc/psm.c
> ==============================================================================
> --- head/sys/dev/atkbdc/psm.c	Mon Sep 26 20:26:19 2016	(r306354)
> +++ head/sys/dev/atkbdc/psm.c	Mon Sep 26 22:06:19 2016	(r306355)
> @@ -389,6 +465,9 @@ TUNABLE_INT("hw.psm.synaptics_support", 
>  static int trackpoint_support = 0;
>  TUNABLE_INT("hw.psm.trackpoint_support", &trackpoint_support);
>  
> +static int elantech_support = 0;
> +TUNABLE_INT("hw.psm.elantech_support", &elantech_support);
> +
>  static int verbose = PSM_DEBUG;
>  TUNABLE_INT("debug.psm.loglevel", &verbose);

It would be good to expose all these tunables as CTLFLAG_RDTUN sysctls.  Exposing
them that way with a decent description string makes it easier for users to
discover tunables.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3815150.rnkVxtqPiv>