Date: Wed, 30 Apr 2003 23:23:17 -0600 From: "Kenneth D. Merry" <ken@kdm.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: scsi@freebsd.org Subject: Re: [patch] Fix for ia64 tinderbox failure Message-ID: <20030430232317.A7644@panzer.kdm.org> In-Reply-To: <20030501001235.GA932@athlon.pn.xcllnt.net>; from marcel@xcllnt.net on Wed, Apr 30, 2003 at 05:12:35PM -0700 References: <20030501001235.GA932@athlon.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 30, 2003 at 17:12:35 -0700, Marcel Moolenaar wrote: > Gang, > > Please review the attached patch to fix the "variable may be used > uninitialized" warning (and thus build failure) on ia64. I just checked in a slightly different fix. I just initialized maxsector and block_len to 0 at the beginning of dagetcapacity(). I guess the ia64 backend isn't as smart as the i386 backend. > Index: scsi_da.c > =================================================================== > RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v > retrieving revision 1.140 > diff -u -r1.140 scsi_da.c > --- scsi_da.c 30 Apr 2003 13:36:51 -0000 1.140 > +++ scsi_da.c 1 May 2003 00:07:59 -0000 > @@ -1821,7 +1821,7 @@ > if (maxsector != 0xffffffff) > goto done; > } else > - goto done; > + goto fail; > > rcaplong = (struct scsi_read_capacity_data_long *)rcap; > > @@ -1858,6 +1858,8 @@ > > if (error == 0) > dasetgeom(periph, block_len, maxsector); > + > +fail: > > xpt_release_ccb(ccb); > Ken -- Kenneth Merry ken@kdm.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030430232317.A7644>