Date: Fri, 12 Apr 2002 13:01:58 -0400 From: Mike Barcroft <mike@FreeBSD.ORG> To: "David O'Brien" <obrien@FreeBSD.ORG> Cc: Ruslan Ermilov <ru@FreeBSD.ORG>, Dag-Erling Smorgrav <des@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: alpha tinderbox failure Message-ID: <20020412130158.H28249@espresso.q9media.com> In-Reply-To: <20020412095128.A97770@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Fri, Apr 12, 2002 at 09:51:28AM -0700 References: <200204111654.g3BGsmc9069057@beast.freebsd.org> <20020412135421.GC27751@sunbay.com> <20020412121212.E28249@espresso.q9media.com> <20020412095128.A97770@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien <obrien@FreeBSD.ORG> writes: > On Fri, Apr 12, 2002 at 12:12:12PM -0400, Mike Barcroft wrote: > > > > I think <machine/endian.h> would be better here. It may not have > > worked because of the missing <sys/cdefs.h> issue. > > We will never get that header included in the GDB sources -- it is > totally FreeBSD (NetBSD also?) specific. It almost sounds like we have a > bug in our headers. Sort of. The way it historically built was by taking advantage of the fact that C allows multiple #define's if they are the same. My commit changed the definition of BYTE_ORDER to _BYTE_ORDER instead of LITTLE_ENDIAN or BIG_ENDIAN. The reason this didn't show up as a problem on i386 was because of a <sys/types.h> include (which includes <machine/endian.h>) earlier in the source file. <machine/endian.h> (apparently this is spelled <endian.h> on other systems) should always be included before fiddling with the byte order manifest constants. Your commit which included <sys/types.h> on alpha "fixed" this problem in the same way the i386 case is "fixed". Where "fixed" is defined as a side-effect of fixing another problem. :) Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020412130158.H28249>