Date: Thu, 07 Jan 2016 17:07:46 -0800 From: Cy Schubert <Cy.Schubert@komquats.com> To: Adrian Chadd <adrian.chadd@gmail.com> Cc: Cy Schubert <Cy.Schubert@komquats.com>, Jeremie Le Hen <jlh@freebsd.org>, Ryan Stone <rysto32@gmail.com>, FreeBSD Current <freebsd-current@freebsd.org>, =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@freebsd.org> Subject: Re: Panic from vesa_configure() Message-ID: <201601080107.u0817kDw078603@slippy.cwsent.com> In-Reply-To: Message from Adrian Chadd <adrian.chadd@gmail.com> of "Thu, 07 Jan 2016 08:53:32 -0800." <CAJ-VmonGOs2f%2BrzciEcV=VuaNrZt0hqNePQx4LZDWu6BxuR9NQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <CAJ-VmonGOs2f+rzciEcV=VuaNrZt0hqNePQx4LZDWu6BxuR9NQ@mail.gmail.c
om>
, Adrian Chadd writes:
> Ok,
>
> So try adding this check:
>
> vmbuf = x86bios_alloc(&offs, sizeof(*buf), M_WAITOK);
> if (vmbuf == NULL) {
> printf("%s: x86bios_alloc failed!\n", __func__);
> goto fail;
> }
>
> ... that call shouldn't be failing, but if it's truely failing on the
> bcopy(), the only reason is because vmbuf is NULL.
Thanks. I'll try this.
vesa.c hasn't changed for a while so I suspect the root cuase may be
somewhere else (we're probably treating the symptom here). Nice thing about
using the same mobo and cpu combination on all my machines (except
laptops), failures are completely reproducible. Might be a good idea to put
in a dtrace probe too.
--
Cheers,
Cy Schubert <Cy.Schubert@komquats.com> or <Cy.Schubert@cschubert.com>
FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201601080107.u0817kDw078603>