Date: Thu, 24 Apr 2008 12:53:46 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> To: Clement Laforet <sheepkiller@cultdeadsheep.org> Cc: freebsd-current@freebsd.org, Ivan Voras <ivoras@freebsd.org> Subject: Re: Http Accept filters (accf_http) Message-ID: <481066BA.1050703@quip.cz> In-Reply-To: <20080423141929.GA61109@goofy.cultdeadsheep.org> References: <8481.1208889581@critter.freebsd.dk> <480E3E66.3000303@samsco.org> <fuli49$pa3$1@ger.gmane.org> <20080423141929.GA61109@goofy.cultdeadsheep.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Clement Laforet wrote: > On Tue, Apr 22, 2008 at 10:34:14PM +0200, Ivan Voras wrote: > >>Scott Long wrote: [...] >>Does anyone know why accf_accept is disabled by default in the ports' >>stock Apache 2.2 (it's disabled in the default config files)? I thought >>it was because it was dangerous or flawed for some reason, though (at >>least for light loads comparable to those of OP) it seems to work fine. > > > There's not technical reason actually. It's an "opt-in" feature ;-) > In the early 2.2.x times, httpd used to print a warning when accf_http > is disabled. It was, of course, just a matter of loglevel. apache ran > perfectly fine, but a warning got printed. Some users started > complaining about how my port was broken, sometimes in very rude > manner. > So I decided to explicilty disable AcceptFilter unless > apache22_http_accept_enable is set to "YES" in /etc/rc.conf. There is another one "problem" with accf_*. Even if modules are loaded, apache on graceful restart prints warning: [Tue Apr 22 02:22:09 2008] [notice] Graceful restart requested, doing restart [Tue Apr 22 02:22:09 2008] [warn] (22)Invalid argument: Failed to enable the 'httpready' Accept Filter [Tue Apr 22 02:22:09 2008] [warn] (22)Invalid argument: Failed to enable the 'httpready' Accept Filter [Tue Apr 22 02:22:09 2008] [warn] (22)Invalid argument: Failed to enable the 'httpready' Accept Filter It is known problem for a long time (as I am seeing it few years). Plain start works without warnings. I have apache controlled by daemontools with run script: exec /usr/local/sbin/httpd -D NO_DETACH -D SSL 2>> /var/log/httpd-error.log Graceful restart done by: kill -USR1 `cat /var/run/httpd.pid` apache-2.2.8 on FreeBSD 7.0-RELEASE i386 GENERIC Miroslav Lachman PS: https://issues.apache.org/bugzilla/show_bug.cgi?id=37863
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?481066BA.1050703>