Date: Fri, 10 Aug 2007 15:41:53 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: bugs@freebsd.org, fs@freebsd.org Subject: Re: msdosfs not MPSAFE Message-ID: <20070810124153.GW2738@deviant.kiev.zoral.com.ua> In-Reply-To: <20070810133946.H769@besplex.bde.org> References: <20070712084115.GA2200@deviant.kiev.zoral.com.ua> <20070712225324.F9515@besplex.bde.org> <20070712142127.GD2200@deviant.kiev.zoral.com.ua> <20070716195556.P12807@besplex.bde.org> <20070721063434.GI2200@deviant.kiev.zoral.com.ua> <20070721233613.Q3366@besplex.bde.org> <20070804075730.GP2738@deviant.kiev.zoral.com.ua> <20070808004001.O926@besplex.bde.org> <20070807170259.GJ2738@deviant.kiev.zoral.com.ua> <20070810133946.H769@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--KCLoHzx0Ylaw/v4x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 10, 2007 at 01:54:48PM +1000, Bruce Evans wrote: > I wrote yet another patch, with allocation on the stack so that no locking > is required. This is simpler and doesn't require any new functions. > Unfortunately, it is larger because it changes the interfaces for most > functions. The interface changes are routine, so this is probably better. > Note that 'struct dirent's are already allocated on the stack. This > patch adds allocation of 'struct mbnambuf's which are slightly smaller > (~256 bytes). I think this is just small enough for stack allocation. I agree that this is the best approach. The size of the on-stack structure still make me worry, although ~270 bytes seems to be not too large for 3-pages stack. --KCLoHzx0Ylaw/v4x Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGvF0RC3+MBN1Mb4gRAnFJAKCJAn0rxD4oSFwYYvFYx2lxSiaUugCfd9xH 4hVyy0x0GC2lo9Grux6PNj0= =2CQF -----END PGP SIGNATURE----- --KCLoHzx0Ylaw/v4x--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070810124153.GW2738>