Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 9 Jul 2014 10:49:47 -0500
From:      Brooks Davis <brooks@freebsd.org>
To:        "Andrey V. Elsukov" <ae@FreeBSD.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Brooks Davis <brooks@FreeBSD.org>, src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   Re: svn commit: r268415 - stable/8/sys/geom
Message-ID:  <20140709154947.GA1070@lor.one-eyed-alien.net>
In-Reply-To: <53BD5F9A.7060801@FreeBSD.org>
References:  <201407081530.s68FU5Dc032932@svn.freebsd.org> <53BD5F9A.7060801@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 09, 2014 at 07:28:26PM +0400, Andrey V. Elsukov wrote:
> On 08.07.2014 19:30, Brooks Davis wrote:
> > Author: brooks
> > Date: Tue Jul  8 15:30:05 2014
> > New Revision: 268415
> > URL: http://svnweb.freebsd.org/changeset/base/268415
> >=20
> > Log:
> >   MFC r223930:
> >  =20
> >   Remove include of sys/sbuf.h from geom/geom.h.
> >   sbuf support is not always required for geom/geom.h users, and no nee=
d to
> >   depend from it.
> >  =20
> >   PR:		158398
>=20
> Hi,
>=20
> I think this will break the build.

It did.  I've backed it out.

> Also this can break third-party software.

Given that 9+ don't include it I doubt that is a serious problem.

-- Brooks

--Kj7319i9nmIyA2yE
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iKYEARECAGYFAlO9ZJtfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDY1NUQ1MTlDMjZBNzgyRTcyNTI5OUJGMDVE
OEU4QkU5RjIzODFBRDQACgkQXY6L6fI4GtSCOACg10WaaG5BnEOlr90v6kz9v37W
JjYAni/pCAN7t/T6HNJmvErhk+niCBVT
=ffBh
-----END PGP SIGNATURE-----

--Kj7319i9nmIyA2yE--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140709154947.GA1070>