Date: Wed, 6 Apr 2011 22:27:28 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Edward Tomasz Napiera?a <trasz@freebsd.org> Cc: Garrett Cooper <yanegomi@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r220387 - head/sys/vm Message-ID: <20110406192728.GH78089@deviant.kiev.zoral.com.ua> In-Reply-To: <28CBF3B2-105E-4B0F-A1B1-4FA772BAB06A@freebsd.org> References: <201104061627.p36GR4Vx097282@svn.freebsd.org> <BANLkTin=xKmJf6HJ%2Beb9CUcnerdv=fNp1w@mail.gmail.com> <28CBF3B2-105E-4B0F-A1B1-4FA772BAB06A@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--j1YqbDUuPtLpE4Xo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 06, 2011 at 07:04:47PM +0200, Edward Tomasz Napiera?a wrote: > Wiadomo?? napisana przez Garrett Cooper w dniu 2011-04-06, o godz. 18:57: > > On Wed, Apr 6, 2011 at 9:27 AM, Edward Tomasz Napierala > > <trasz@freebsd.org> wrote: > >> Author: trasz > >> Date: Wed Apr 6 16:27:04 2011 > >> New Revision: 220387 > >> URL: http://svn.freebsd.org/changeset/base/220387 > >>=20 > >> Log: > >> In vm_daemon(), do not skip processes stopped with SIGSTOP. > >=20 > > Did you run this by anyone else before you committed the change? >=20 > The whole racct patchset was reviewed by kib@, and I seem to remember > that he said this might cause problems. However, I didn't encounter > any problems with this, neither did any person testing the patchset. >=20 > So, what's wrong with this? I remember that I disliked the whole approach of handling RSS limits, and still hold the same opinion. I said something about honoring the limit at the time of page allocation or page-in, and not `offline' as it is committed, by periodic scans by daemon. I do not think that r220387 is much problematic. It performs forced pageout of usermode pages, that it. On the other hand, a commit message is not very accurate, thread inhibitor TDI_SUSPENDED might be set e.g. due to single-threading event, and then we could end up swapping out the vmspace that is going to be destroyed due to exec(2). --j1YqbDUuPtLpE4Xo Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk2cvp8ACgkQC3+MBN1Mb4hIBQCfbwu/kIo4K8vCTfkVLNiWCdOm WW8AnA6hIo2pEQ1b9Utf61kewAlm3VPa =dxtr -----END PGP SIGNATURE----- --j1YqbDUuPtLpE4Xo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110406192728.GH78089>