Date: Tue, 25 May 2010 22:30:51 -0700 From: Neel Natu <neelnatu@gmail.com> To: "C. Jayachandran" <c.jayachandran@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: Fixes to the new pagetable page allocation code. Message-ID: <AANLkTim-be1YNot7fTSC8leHPuNp5003ku-78rbAI4at@mail.gmail.com> In-Reply-To: <AANLkTiluuD6YtgYBRj25FixyzGyrGNwQZmvB_nOeCFWN@mail.gmail.com> References: <AANLkTiluuD6YtgYBRj25FixyzGyrGNwQZmvB_nOeCFWN@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi JC, On Tue, May 25, 2010 at 10:03 PM, C. Jayachandran <c.jayachandran@gmail.com> wrote: > The attached patch (also at > http://people.freebsd.org/~jchandra/for-review/pmap-alloc-page-fix.diff) > has two fixes for the new pagetable page allocation code, one to > handle NULL return from the allocating function, and another to call > VM_WAIT in cases we can wait. It also removes the variable 'req' left > over from an earlier change. > > Please let me know if you have any comments... > Your patch looks fine. Checking the value of 'ptdpg' is redundant given that you are passing in M_WAITOK. I don't think we expect the allocation to fail now that you have added the check for M_WAITOK in zone allocator function. best Neel > JC. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim-be1YNot7fTSC8leHPuNp5003ku-78rbAI4at>