Date: Mon, 14 Apr 2003 12:40:56 -0400 (EDT) From: "Matthew N. Dodd" <mdodd@FreeBSD.ORG> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c Message-ID: <20030414124016.O39446@sasami.jurai.net> In-Reply-To: <20030414.102923.58074053.imp@bsdimp.com> References: <200304140945.h3E9jPCe005099@repoman.freebsd.org> <20030414.102923.58074053.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Apr 2003, M. Warner Losh wrote: > In message: <200304140945.h3E9jPCe005099@repoman.freebsd.org> > Maxim Sobolev <sobomax@FreeBSD.org> writes: > : Before attaching device set PCIM_CMD_PORTEN in addition to > : PCIM_CMD_MEMEN and PCIM_CMD_BUSMASTEREN, becaise some braindead > : BIOSes (such as one found in my vprmatrix notebook) forget > : to initialize it properly resulting in attachment failure. > > Actually, code like this should be the pci bus, since all driver have > this issue... Likely this could be added to the bus_alloc_resource() path... Doing a sanity check on requests and then enabling the resource seems like the correct solution. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030414124016.O39446>