Date: Wed, 05 Feb 1997 14:00:50 -0800 From: David Greenman <dg@root.com> To: Brian McGovern <bmcgover@cisco.com> Cc: support@freebsd.org, hackers@freebsd.org Subject: Re: Stomp the bug!!!! (Was cyclades bug) Message-ID: <199702052200.OAA11374@root.com> In-Reply-To: Your message of "Wed, 05 Feb 1997 16:26:57 EST." <199702052126.QAA00718@bmcgover-pc.cisco.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>Boy, I hate when things are obvious. > >The line: > >outw(ioport + CY_PLX_ICS, inw(CY_PLX_ICS) | > CY_PLX_ICS_IENABLE | CY_PLX_ICS_LOCAL_IENABLE); > >is wrong. The inw doesn't have the ioport offset, and should read: > >outw(ioport + CY_PLX_ICS, inw(ioport + CY_PLX_ICS) | > CY_PLX_ICS_IENABLE | CY_PLX_ICS_LOCAL_IENABLE); > > >Otherwise, the inw doesn't read from the same register as you outw to. If >someome would like me to diff this up, let me know. Otherwise, I'll assume >the change will get committed? > >Gee, I feel good. My first bug fix. THANKS!!! Yes, that is indeed a stupid bug and likely causes all sorts of bad things to happen. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199702052200.OAA11374>