Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Feb 2003 21:50:31 +0200
From:      Alexey Zelkin <phantom@FreeBSD.org.ua>
To:        Alfred Perlstein <alfred@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, legacy-committers@FreeBSD.org
Subject:   Re: cvs commit: src/include pthread.h src/lib/libc_r/uthread uthread_attr_getstack.c uthread_attr_setstack.c src/lib/libpthread/thread thr_attr_getstack.c thr_attr_setstack.c src/lib/libc_r/man pthread_attr.3
Message-ID:  <20030210215031.A28553@phantom.cris.net>
In-Reply-To: <20030210105459.GU88781@elvis.mu.org>; from alfred@FreeBSD.org on Mon, Feb 10, 2003 at 02:54:59AM -0800
References:  <200302100848.h1A8m4Fj054987@repoman.freebsd.org> <20030210120147.A25796@phantom.cris.net> <20030210105459.GU88781@elvis.mu.org>

next in thread | previous in thread | raw e-mail | index | archive | help
hi,

On Mon, Feb 10, 2003 at 02:54:59AM -0800, Alfred Perlstein wrote:
> > On Mon, Feb 10, 2003 at 12:48:04AM -0800, Alfred Perlstein wrote:
> > >   Log:
> > >   Add pthread_attr_getstack() and pthread_attr_setstack().
> 
> * Alexey Zelkin <phantom@FreeBSD.org.ua> [030210 01:55] wrote:
> > hi,
> > 
> > Who reviewed this change ?  Did you told to Dan before doing it ?
> 
> I thought it was fine, I've done work on the pthreads library before.

Dan is owning some uncommitted patches used to convert libc_r to using
*context() stuff, instead of longjmp()'s.  Making uncoordinated changes
just may create unneeded problems, IMO.

> > And last, that purpose of this functionality ?  (I have seen a diff,
> > but it's interesting how these functions are supposed to be used?)
> 
> This is to bring us a function that is required by:
> http://www.opengroup.org/onlinepubs/007904975/functions/pthread_attr_getstack.html

Hmm..  Reading of -committers before morning coffee isn't good idea.

Sorry Alfred.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030210215031.A28553>