Date: Wed, 2 Oct 2002 04:02:36 +0200 From: "Niels Chr. Bank-Pedersen" <ncbp@bank-pedersen.dk> To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> Cc: jhb@FreeBSD.ORG, mmcgoldrick@linuxdriven.net, current@FreeBSD.ORG Subject: Re: PCI brokenness Message-ID: <20021002020235.GA47844@bank-pedersen.dk> In-Reply-To: <20021002.084110.69705085.iwasaki@jp.FreeBSD.org> References: <20021001211543.GA607@uriel.fakedomain.net> <XFMail.20021001172334.jhb@FreeBSD.org> <20021002.084110.69705085.iwasaki@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 02, 2002 at 08:41:10AM +0900, Mitsuru IWASAKI wrote:
> Hi,
>
[...]
> > Can you try with the stuff I committed yesterday? It fixed the case (for
> > my tests at least) of legacy0 failing to attach or probe when acpi failed
> > to attach.
>
> If still failed, please try this.
> I've noticed that no chance to call pci_cfgregopen() before probing
> PCI children in case Host PCI bridge _CRS is not method or _INI method
> don't access to PCI config space or something.
>
> Thanks
>
> Index: acpi_pcib_acpi.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_acpi.c,v
> retrieving revision 1.23
> diff -u -r1.23 acpi_pcib_acpi.c
> --- acpi_pcib_acpi.c 26 Aug 2002 18:30:27 -0000 1.23
> +++ acpi_pcib_acpi.c 1 Oct 2002 23:17:51 -0000
> @@ -114,6 +115,9 @@
> !acpi_disabled("pci") &&
> acpi_MatchHid(dev, "PNP0A03")) {
>
> + if (!pci_cfgregopen())
> + return(ENXIO);
> +
> /*
> * Set device description
> */
> Index: acpi_pcib_pci.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_pci.c,v
> retrieving revision 1.1
> diff -u -r1.1 acpi_pcib_pci.c
> --- acpi_pcib_pci.c 26 Aug 2002 18:30:27 -0000 1.1
> +++ acpi_pcib_pci.c 1 Oct 2002 23:18:38 -0000
> @@ -114,6 +115,9 @@
> return (ENXIO);
> if (acpi_get_handle(dev) == NULL)
> return (ENXIO);
> + if (!pci_cfgregopen())
> + return (ENXIO);
> +
> device_set_desc(dev, "ACPI PCI-PCI bridge");
> return (-1000);
> }
Thanks! - this patch fixes the problems I've had with missing
PCI devices.
Regards,
Niels Chr.
--
Niels Christian Bank-Pedersen, NCB1-RIPE.
"Hey, are any of you guys out there actually *using* RFC 2549?"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021002020235.GA47844>