Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Feb 2011 20:19:52 +0100
From:      Pawel Worach <pawel.worach@gmail.com>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r218192 - head/sbin/hastd
Message-ID:  <CA6000A5-5101-40C4-9A51-41F49153E35C@gmail.com>
In-Reply-To: <201102021542.p12Fg05o013711@svn.freebsd.org>
References:  <201102021542.p12Fg05o013711@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Feb 2, 2011, at 16:42, Pawel Jakub Dawidek wrote:
> Author: pjd
> Date: Wed Feb  2 15:42:00 2011
> New Revision: 218192
> URL: http://svn.freebsd.org/changeset/base/218192
>=20
> Log:
>  Allow to specify connection timeout by the caller.
>=20
>  MFC after:	1 week
>=20
> Modified:
>  head/sbin/hastd/primary.c
>  head/sbin/hastd/proto.c
>  head/sbin/hastd/proto.h
>  head/sbin/hastd/proto_impl.h
>  head/sbin/hastd/proto_tcp4.c
>  head/sbin/hastd/proto_uds.c
>=20
...
> int
> -proto_connect(struct proto_conn *conn)
> +proto_connect(struct proto_conn *conn, int timeout)
> {

Hi Pawel,

I think you missed to updated a call.

=
/data/buildslave/freebsd-clang-amd64/obj/obj-llvm.2/Release+Asserts/bin/cl=
ang -isysroot =
/data/buildslave/freebsd-clang-amd64/obj/obj-freebsd/data/buildslave/freeb=
sd-clang-amd64/src-freebsd/tmp =
-B/data/buildslave/freebsd-clang-amd64/obj/obj-freebsd/data/buildslave/fre=
ebsd-clang-amd64/src-freebsd/tmp/usr/lib/ =
-L/data/buildslave/freebsd-clang-amd64/obj/obj-freebsd/data/buildslave/fre=
ebsd-clang-amd64/src-freebsd/tmp/usr/lib/ -O2 -pipe  =
-I/data/buildslave/freebsd-clang-amd64/src-freebsd/sbin/hastctl/../hastd =
-DINET -DINET6 -DYY_NO_UNPUT -DYY_NO_INPUT -DHAVE_CRYPTO -std=3Dgnu99 =
-fstack-protector -Qunused-arguments -Wsystem-headers -Wall =
-Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes =
-Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual =
-Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align =
-Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls =
-Wold-style-definition -Wno-pointer-sign -c =
/data/buildslave/freebsd-clang-amd64/src-freebsd/sbin/hastctl/hastctl.c
=
/data/buildslave/freebsd-clang-amd64/src-freebsd/sbin/hastctl/hastctl.c:49=
0:31: error: too few arguments to function call, expected 2, have 1
        if (proto_connect(controlconn) < 0) {
            ~~~~~~~~~~~~~            ^
1 error generated.

Regards
--=20
Pawel





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA6000A5-5101-40C4-9A51-41F49153E35C>