Date: Wed, 28 Jul 2004 18:12:48 +0200 From: Max Laier <max@love2party.net> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys _task.h Message-ID: <200407281812.57274.max@love2party.net> In-Reply-To: <20040728160852.GA21481@Odin.AC.HMC.Edu> References: <200407280912.i6S9CsfA088910@repoman.freebsd.org> <20040728091920.GU82302@elvis.mu.org> <20040728160852.GA21481@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-02=_JC9BBZa0R1iIAba Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 28 July 2004 18:08, Brooks Davis wrote: > On Wed, Jul 28, 2004 at 11:19:20AM +0200, Maxime Henrion wrote: > > Maxime Henrion wrote: > > > mux 2004-07-28 09:12:54 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/sys _task.h > > > Log: > > > Remove (at least temporarily) the check that prevents us from > > > including this file from userland. Since we export struct ifnet to > > > userland, and that struct ifnet now contains a struct task, userland > > > needs to know what struct task looks like. > > > > > > We need to consider having a pointer to a struct task here instead > > > and forward declare struct task in the !_KERNEL case. > > > > Or have a struct ifnet for kernel and a struct xifnet for userland, as = we > > do in other places. > > No, that won't work. There is no valid reason for userland applications > to use struct ifnet. They only use it because the authors were lazy > and access things like interface stats via kvm access to ifnet instead > of via the generally adaquate sysctls. I'm seriously tempted to wrap > if_var.h in something like, at least once we get our useland clean: > > #if defined(_KERNEL) || defined(IF_VAR_H_IS_NOT_A_VALID_USERLAND_INTERFAC= E) Strongly seconded! Everything the userland needs to know about interfaces=20 should come from sysctls or <net/if.h> via ioctls. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-02=_JC9BBZa0R1iIAba Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBBB9CJXyyEoT62BG0RAvBqAJ0aIlJRIBtqUl/dyTIowqXF3tBT2gCfZiIj Ov8b7vbfjU0JShxBHqnfD+U= =wnXR -----END PGP SIGNATURE----- --Boundary-02=_JC9BBZa0R1iIAba--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407281812.57274.max>