Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Nov 1996 08:24:55 +0300 (MSK)
From:      =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (Andrey A. Chernov) <ache@nagual.ru>
To:        toor@dyson.iquest.net (John S. Dyson)
Cc:        toor@dyson.iquest.net, current@freebsd.org, dyson@freebsd.org
Subject:   Re: MSDOS lkm just broken (MAXBSIZE)
Message-ID:  <199611300524.IAA00552@nagual.ru>
In-Reply-To: <199611300214.VAA09459@dyson.iquest.net> from "John S. Dyson" at "Nov 29, 96 09:14:02 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
> THE SYSTEM NEVER SUPPORTED 32K out of the BOX!!!  MSDOS WAS ASKING
> FOR THE IMPOSSIBLE!!!

MSDOS asking for impossible because you instruct it to do so:

msdosfs_vfsops.c:		pmp->pm_fatblocksize = MAXBSIZE;

MAXBZSIZE = 32K for MSDOS lkm, because MSDOSFS is defined


> Sorry, but unless you were running with MAXBSIZE=32K you were
> heading for trouble.  You can remove the check(panic), and get exactly
> what you would have before...  A potentially corrupted filesystem.  The
> only reason that you have not had a corrupted file system is by
> chance...  Sorry again, that is the situation.  I am working on
> a real solution, and hackery is NOT in the plan.

It seems that

1) you introduce this corruption first
2) then check for it and panic

For old variant

msdosfs_vfsops.c:		pmp->pm_fatblocksize = MAXBSIZE;

was evaluated to 16K and not cause corruption.

-- 
Andrey A. Chernov
<ache@nagual.ru>
http://www.nagual.ru/~ache/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611300524.IAA00552>