Date: Thu, 10 Jun 2010 20:10:03 GMT From: ports@c0decafe.net To: gnome@FreeBSD.org Subject: Re: ports/147655: [PATCH] textproc/libxslt: remove USE_GETTEXT=yes Message-ID: <201006102010.o5AKA3ZK026724@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/147655; it has been noted by GNATS. From: ports@c0decafe.net To: Sunpoet Hsieh <sunpoet@sunpoet.net> Cc: freebsd-ports-bugs@freebsd.org, bug-followup@freebsd.org Subject: Re: ports/147655: [PATCH] textproc/libxslt: remove USE_GETTEXT=yes Date: Thu, 10 Jun 2010 23:08:04 +0300 Helo, On Thu, Jun 10, 2010 at 9:27 AM, Sunpoet Hsieh <sunpoet@sunpoet.net> wrote: > On Thu, Jun 10, 2010 at 5:59 AM, ports@c0decafe.net <ports@c0decafe.net> = wrote: >> On Mon, 07 Jun 2010 23:51:51 +0800, Sunpoet Po-Chuan Hsieh wrote: >>> gettext dependency was added to libxslt if CRYPTO option is on (by >>> default). However, libxslt does not link against gettext library if >>> libgpg-error was built without NLS support (WITHOUT_NLS option). Thus I >>> think USE_GETTEXT should be removed. >>> >>> Dependency tree: >>> libxslt ---> libgcrypt ---> libgpg-error ---> gettext >>> =A0 =A0 =A0depends on =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(condi= tional) >> >> I'm not sure it is that simple. >> Consider the following: >> gmake[3]: Entering directory `/build/usr/ports/devel/eggdbus/work/ >> eggdbus-0.6/docs/man' >> /usr/local/bin/xsltproc -nonet http://docbook.sourceforge.net/release/xs= l/ >> current/manpages/docbook.xsl eggdbus-binding-tool.xml >> /libexec/ld-elf.so.1: Shared object "libintl.so.8" not found, required b= y >> "libgcrypt.so.16" > For me, I build libgpg-error without gettext (WITHOUT_NLS=3Dyes), thus > my libxslt does not require gettext. yes, but can WITHOUT_NLS guarantee that all dependencies are gettext safe? If so, we could just make it actually respect WITHOUT_NLS: --- Makefile.orig 2010-06-10 22:29:02.000000000 +0300 +++ Makefile 2010-06-10 22:31:57.000000000 +0300 @@ -46,7 +46,9 @@ .if defined(WITH_CRYPTO) LIB_DEPENDS+=3D gcrypt.16:${PORTSDIR}/security/libgcrypt +.if !defined(WITHOUT_NLS) USE_GETTEXT=3D yes +.endif .else CONFIGURE_ARGS+=3D--without-crypto .endif But i still see some serious breakages potential: race conditions, etc. For the general use case, an implicit dependency might still be there. Only USE_GETTEXT +bumps are safe for all the possible scenarios. Just thoughts.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006102010.o5AKA3ZK026724>