Date: Mon, 31 Aug 2015 06:22:46 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Dirk Meyer <dirk.meyer@dinoex.sub.org> Cc: svn-ports-all@freebsd.org Subject: Re: svn commit: r395527 - in head/graphics/jasper: . files Message-ID: <20150831062246.GA49457@FreeBSD.org> In-Reply-To: <xtBletsm0A@dmeyer.dinoex.sub.org> References: <201508290619.t7T6Js6d029551@repo.freebsd.org> <201508290619.t7T6Js6d029551@repo.freebsd.org> <20150829081543.GA8460@FreeBSD.org> <xtBletsm0A@dmeyer.dinoex.sub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 29, 2015 at 05:01:02PM +0200, Dirk Meyer wrote: > Hallo Alexey Dokuchaev, > > > -USES= jpeg libtool:keepla zip > > > +USES= zip libtool:keepla jpeg > > > > Sorry, but why did you shuffle previously sorted values? > > I keep them sorted by function / stage (extract, configure). > Sorting them by alphabetic name is confusing to me. The problem here Dirk is that now it's confusing to everyone else. No offense, but sometimes your ports have higher than usual wtf/sec ratio when reading through them. :) There're certain I won't say rules, but rather established practices and patterns that became quite common and expected to see because they suit most developers (not all are necessarily documented and/or enforced, as I've said). So while you're in your maintainer right to unsort USES, bear in mind that 1) it was gratuitous change which we typically try to avoid: that does not mean you can't change USES order -- that's fine when adding or removing another USES entry -- but that was not the case; 2) it raises chances that someone else comes after you and "fixes" it, well, because for most people alphabet does not start with 'z', and 3) seeing "weird" code, and that includes make(1) code as well, can often kill any desire to work on it. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150831062246.GA49457>