Date: Wed, 05 Sep 2001 18:37:28 -0700 From: Mike Smith <msmith@freebsd.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: hackers@freebsd.org Subject: Re: proposed change to pci_pci.c Message-ID: <200109060137.f861bSO05433@mass.dis.org> In-Reply-To: Message from Brooks Davis <brooks@one-eyed-alien.net> of "Wed, 05 Sep 2001 17:43:27 PDT." <20010905174327.A3591@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
I'd be OK with this being done as a hack for now. I think the bridge code needs to be a bit kinder about allowing "stupid" things to be done if they're set up by the BIOS. > I'd like to propose committing the following change which adds a new > undocumented option in the spirit of PCI_ENABLE_IO_MODES. The new option > (PCI_ALLOW_UNSUPPORTED_IO_RANGE) allows me to boot my old HP Omnibook > 4150 while docked. Since I've seen a couple other people need this fix, > I figure it would be more useful if they just had to add a line to their > kernel config instead of editing the source files. Any objections? > > -- Brooks > > Index: pci_pci.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/sys/dev/pci/pci_pci.c,v > retrieving revision 1.3 > diff -u -r1.3 pci_pci.c > --- pci_pci.c 13 Dec 2000 01:25:11 -0000 1.3 > +++ pci_pci.c 7 Jun 2001 17:31:50 -0000 > @@ -286,7 +286,9 @@ > " (decoding 0x%x-0x%x)\n", > device_get_name(child), device_get_unit(child), start, end, > sc->iobase, sc->iolimit); > +#ifndef PCI_ALLOW_UNSUPPORTED_IO_RANGE > return(NULL); > +#endif > } > if (bootverbose) > device_printf(sc->dev, "device %s%d requested decoded I/O range 0x%lx-0x= > %lx\n", > @@ -306,7 +308,9 @@ > " (decoding 0x%x-0x%x, 0x%x-0x%x)\n", > device_get_name(child), device_get_unit(child), start, end, > sc->membase, sc->memlimit, sc->pmembase, sc->pmemlimit); > +#ifndef PCI_ALLOW_UNSUPPORTED_IO_RANGE > return(NULL); > +#endif > } > if (bootverbose) > device_printf(sc->dev, "device %s%d requested decoded memory range 0x%lx= > -0x%lx\n", > > --=20 > Any statement of the form "X is the one, true Y" is FALSE. > PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 > > --ZGiS0Q5IWpPtfppv > Content-Type: application/pgp-signature > Content-Disposition: inline > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.0.6 (GNU/Linux) > Comment: For info see http://www.gnupg.org > > iD8DBQE7lsauXY6L6fI4GtQRAlYkAJ9BS8yO/HeRrVEmbp0HRZLy0VX/zQCfcwqI > 1TsAzTG5bFfK4NHTz7Kk+O8= > =Nu3h > -----END PGP SIGNATURE----- > > --ZGiS0Q5IWpPtfppv-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109060137.f861bSO05433>