Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Jan 2010 11:50:39 GMT
From:      Rafal Jaworowski <raj@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 173823 for review
Message-ID:  <201001281150.o0SBodEO035108@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/chv.cgi?CH=173823

Change 173823 by raj@raj_fdt on 2010/01/28 11:50:30

	Simplify handling #address-cells and #size-cells in LBC attachment.

Affected files ...

.. //depot/projects/fdt/sys/powerpc/mpc85xx/lbc.c#4 edit

Differences ...

==== //depot/projects/fdt/sys/powerpc/mpc85xx/lbc.c#4 (text+ko) ====

@@ -320,14 +320,8 @@
 	int tuple_size, tuples;
 	int i, rv, bank;
 
-	addr_cells = fdt_parent_addr_cells(node);
-	if (addr_cells > 0) {
-		rv = OF_searchprop(OF_parent(node), "#size-cells",
-		    &size_cells, sizeof(size_cells));
-		if (rv <= 0)
-			size_cells = 1;
-	} else
-		size_cells = 0;
+	if (fdt_addrsize_cells(OF_parent(node), &addr_cells, &size_cells) != 0)
+		return (ENXIO);
 
 	tuple_size = sizeof(pcell_t) * (addr_cells + size_cells);
 	tuples = OF_getprop_alloc(node, "reg", tuple_size, (void **)&reg);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001281150.o0SBodEO035108>