Date: Tue, 12 Oct 2010 08:42:14 +1100 From: Adrian Thearle <adrian@thearle.com.au> To: delphij@FreeBSD.org, FreeBSD-ports-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/151388: [PATCH] mail/postfix-gps: OPTIONS added for other databases Message-ID: <4CB384B6.9050001@thearle.com.au> In-Reply-To: <201010111658.o9BGwLhg004044@freefall.freebsd.org> References: <201010111658.o9BGwLhg004044@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I guess from my point of view they are separate problems. The
libdbi-drivers package is configured separately, and I ensure that I
compile it with postgresql support. My understanding of the ports is
that if a dependant port is not configured correctly, then one needs
enough understanding of the error message to find and recompile the
dependant port. I just thought this was a limitation of the ports system.
We could add a check to look for
libdbdpgsql.so/libdbmysql.so/libdbdsqlite.so and mark the port as broken
if the one required by the options is not there. It could provide a
meaningful error explaining that they need to recompile libdbi-drivers
with pgsql/mysql/sqlite support.
something like
.if !defined(WITHOUT_PGSQL)
.if !exists(${LOCALBASE}/lib/libdbdpgsql.so)
#if we get here, then the ports system should have already installed
libdbi-drivers, so it should be safe to assume the library is installed
BROKEN= libdbi-drivers was not compiled with postgresql support, please
run 'make options' at libdbi-drivers and reinstall.
.endif
.endif
The second part is still a valid fix, is it not? It adds the right
runtime dependency for the options specified, and if libdbi-drivers has
been compiled correctly, then the end result is a working port.
Cheers
Adrian
On 12/10/2010 3:58 AM, delphij@FreeBSD.org wrote:
> Synopsis: [PATCH] mail/postfix-gps: OPTIONS added for other databases
>
> State-Changed-From-To: open->feedback
> State-Changed-By: delphij
> State-Changed-When: Mon Oct 11 16:40:49 UTC 2010
> State-Changed-Why:
> Hi,
>
> I am aware of the problem but the proposed fix won't work,
> unfortunately, since the C part of the daemon needs a
> multiple database enabled libdbi-drivers package to work.
>
> Without the ability to depend on libdbi-drivers support,
> the change you have proposed will only effective on the
> perl maintainence part of the postfix-gps port.
>
> So I think I will have to close or mark this suspend if
> we don't have better solutions :(
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=151388
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CB384B6.9050001>