Date: Thu, 28 Mar 2013 07:32:05 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: mdf@FreeBSD.org Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: [RFC] use a shared lock for VOP_GETEXTATTR Message-ID: <20130328053205.GF3794@kib.kiev.ua> In-Reply-To: <CAMBSHm9VgD9Pcmiap3Cy1eW8GD9k06q%2BsCzaSJ%2B_wyA6ZFioTA@mail.gmail.com> References: <CAMBSHm8Akz2-tUhjYm9%2BH3YTN31N8=OhGHX1ZpdV4-VixFQm%2BQ@mail.gmail.com> <CAMBSHm9VgD9Pcmiap3Cy1eW8GD9k06q%2BsCzaSJ%2B_wyA6ZFioTA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--MZTSf4zogrZAfwtT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 27, 2013 at 06:37:51PM -0700, mdf@FreeBSD.org wrote: > VOP_GETEXTATTR is currently called with an exclusive lock, which seems > like overkill for what is essentially a read operation. I had a look > over the various in-tree filesystems and it didn't look like any of > them will have a problem if a shared-mode lock is used for > vop_getextattr. >=20 > Does anyone know otherwise? Is someone using extended attributes > regularly who can test this? I think this change should be fine. At least it seems to for UFS. What other filesystems did you audited ? --MZTSf4zogrZAfwtT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRU9XUAAoJEJDCuSvBvK1BKGgP+warWw/Mo9pcf9zIj+cBE3PZ 9sdXjWUcCKqIM1pOFlURH2odq9P1+5Va7wP2n5jYBYUdri0SoCfQ/C86jvUkvaNS xKrMtNXIq38eKCCWU34+rFNhF9bg+rS0KS8FXI5+nnsbDsWaB0PeCXBSrfudeTv+ HFfGFmGLQvJdzYfvZ6LWInWw8BhgyrLX0/A/xAnPwlZDLrw1RbtAL51XRH/PHliv KfsxlyMoiTqJLDR7jX0EPiIcg+WENyUgwQ/SJTZ4i3a52y8eXLlSzHIhrinHPmnE b3iCc3TTZCRJYx0cOJMjLzk/d1kIVTYgRZ+Sdap1UjHeFw+E8Ps3Ev2T3BCzYCzG eTZBdffzcDW6xxc7zYfNDeiUvKEq3uKsBY9AyQeZWn5vEOsFSYFXc4TV/Q/OT+VM /hcdbgqcjDh2rXVJo1XHkpb+6mMZN4HWOo/r8Q+jVk2q/5RCmeQCN8tmbmWI4jIr j/hYA4zvH6cuEJ3iDghDV4urgb11VZ/Ybyx3At26J4jlUqW0B9MvIbvyRTnGiQt5 A95rE6tR0sfiMCRYrXs+pWR82DboNtv5PaQ6Wo5M+/hcweU1xjuJ/ris6EJVXUuU vcHp2dGMabmPzzFNPuN6lLh0VtOx1M57wJ/3ZV6xdDdZAeKrI0/GoU+CvqT/ONPR pPPVG6W9gpNZ8OpRB1sl =4mql -----END PGP SIGNATURE----- --MZTSf4zogrZAfwtT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130328053205.GF3794>