Date: Tue, 9 Jun 2015 20:05:55 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284167 - head/sys/i386/i386 Message-ID: <14AE3E08-5D5D-437F-A2D3-C89A8CF4B0C1@FreeBSD.org> In-Reply-To: <20150609162836.C935@besplex.bde.org> References: <201506082012.t58KCjZX023061@svn.freebsd.org> <20150609162836.C935@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_F0EFAA0E-FAE0-4F0D-A1A6-109D8BF54FD9 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 09 Jun 2015, at 08:44, Bruce Evans <brde@optusnet.com.au> wrote: > > On Mon, 8 Jun 2015, Dimitry Andric wrote: > >> Log: >> Merge r283870 from amd64: >> >> Remove unneeded NULL checks in trap_fatal(). >> >> Since td_name is an array member of struct thread, it can never be NULL, >> so the check can be removed. In addition, curproc can never be NULL, >> so remove the if statement, and splice the two printfs() together. >> >> While here, remove the u_long cast, and use the correct printf format >> specifier for curproc->p_pid. >> >> Requested by: jhb > > Er. I gave a longer review which implicity requested not doing all of > this. The format was correct (it matched the cast), and the cast was > less wrong than not casting. Please read https://reviews.freebsd.org/D2695, where Kostik argued "pid_t is int32_t on all arches", and I agreed with that. The previous obfuscation is unnecessary now. > Both amd64/trap.c i386/trap.c still print pids portably (by casting > to long) in one place. They each had 2 unportable printings of pids; > now they each have 3 unportable printings of pids. I wasn't updating the other parts of the code, so I stayed out of there for now. Feel free to put a review in Phabricator to make everything consistent. -Dimitry --Apple-Mail=_F0EFAA0E-FAE0-4F0D-A1A6-109D8BF54FD9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlV3Kw4ACgkQsF6jCi4glqN3yQCgvk6xfYmX+RtDRGUePIorZfBO xWAAoMUJsnZoVcztyLSBW2bnaeyOgvA4 =XhHI -----END PGP SIGNATURE----- --Apple-Mail=_F0EFAA0E-FAE0-4F0D-A1A6-109D8BF54FD9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14AE3E08-5D5D-437F-A2D3-C89A8CF4B0C1>