Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Oct 1999 01:34:25 +0300 (EEST)
From:      netch@lucky.net (Valentin Nechayev)
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/14443: ports/misc/screen screen-3.9.5 fix
Message-ID:  <199910202234.BAA05354@nn.kiev.ua>

next in thread | raw e-mail | index | archive | help

>Number:         14443
>Category:       ports
>Synopsis:       ports/misc/screen screen-3.9.5 fix
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 20 15:40:00 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Valentin Nechayev
>Release:        FreeBSD 3.3-STABLE i386
>Organization:
Lucky Net Ltd.
>Environment:

FreeBSD 3.3-19991003-STABLE i386
ports/misc/screen port of Sep, 19

>Description:

1. configure script incorrectly detects type of getloadavg() arguments:

=== cut config.h ===
#define LOADAV 1

#define LOADAV_NUM 3
#define LOADAV_TYPE long
#define LOADAV_SCALE FSCALE
#define LOADAV_GETLOADAVG 1
/* #undef LOADAV_UNIX */
/* #undef LOADAV_AVENRUN */
=== end cut ===
=== cut MakeLog ===
cc -c -I. -I.    -O -pipe -g loadav.c
loadav.c: In function `GetLoadav':
loadav.c:101: warning: passing arg 1 of `getloadavg' from incompatible pointer type
=== end cut ===

2. teln.c source file causes annoying warnings:

In file included from teln.c:31:
/usr/include/arpa/inet.h:89: warning: parameter has incomplete type
/usr/include/arpa/inet.h:92: warning: parameter has incomplete type
/usr/include/arpa/inet.h:96: warning: parameter has incomplete type

>How-To-Repeat:

Try make it.

>Fix:
	
In configure script, disable explicit bug in code -
"#if <...> || !(defined(__osf__) && defined(__alpha)) || <...>"
In teln.c, include <netinet/in.h>.

=== cut patch1 ===
--- configure.orig	Mon Aug  2 15:26:53 1999
+++ configure	Thu Oct 21 01:08:47 1999
@@ -2706,7 +2706,7 @@
 
 _CUT_HERE_
 
-#if ((defined(hp300) && !defined(__hpux)) || defined(sun) || (defined(ultrix) && defined(mips)) || defined(_SEQUENT_) || defined(sgi) || defined(SVR4) || defined(sony_news) || !(defined(__osf__) && defined(__alpha)) || defined(_IBMR2) || defined(_AUX_SOURCE) || defined(AUX) || defined(m88k))
+#if ((defined(hp300) && !defined(__hpux)) || defined(sun) || (defined(ultrix) && defined(mips)) || defined(_SEQUENT_) || defined(sgi) || defined(SVR4) || defined(sony_news) || defined(_IBMR2) || defined(_AUX_SOURCE) || defined(AUX) || defined(m88k))
 loadtype=long
 # if defined(apollo) || defined(_IBMR2) || defined(_AUX_SOURCE) || defined(AUX)
 loadscale=65536
=== end cut ===

=== cut patch2 ===
--- configure.in.orig	Mon Aug  2 15:26:50 1999
+++ configure.in	Thu Oct 21 01:14:17 1999
@@ -862,7 +862,7 @@
 #include <sys/types.h>
 #include <sys/param.h>
 ],[
-#if ((defined(hp300) && !defined(__hpux)) || defined(sun) || (defined(ultrix) && defined(mips)) || defined(_SEQUENT_) || defined(sgi) || defined(SVR4) || defined(sony_news) || !(defined(__osf__) && defined(__alpha)) || defined(_IBMR2) || defined(_AUX_SOURCE) || defined(AUX) || defined(m88k))
+#if ((defined(hp300) && !defined(__hpux)) || defined(sun) || (defined(ultrix) && defined(mips)) || defined(_SEQUENT_) || defined(sgi) || defined(SVR4) || defined(sony_news) || defined(_IBMR2) || defined(_AUX_SOURCE) || defined(AUX) || defined(m88k))
 loadtype=long
 # if defined(apollo) || defined(_IBMR2) || defined(_AUX_SOURCE) || defined(AUX)
 loadscale=65536
=== end cut ===

=== cut patch3 ===
--- teln.c.orig	Wed Jul 28 15:50:22 1999
+++ teln.c	Thu Oct 21 01:15:50 1999
@@ -28,6 +28,7 @@
 #include <sys/socket.h>
 #include <fcntl.h>
 #include <netdb.h>
+#include <netinet/in.h>
 #include <arpa/inet.h>
 
 #include "config.h"
=== end cut ===

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199910202234.BAA05354>