Date: Sat, 13 Nov 2010 01:55:30 +0100 From: Michal Varga <varga.michal@gmail.com> To: Anonymous <swell.k@gmail.com> Cc: thomas.e.zander@googlemail.com, Christian Weisgerber <naddy@mips.inka.de>, freebsd-ports@freebsd.org Subject: Re: [CFT] mplayer / mencoder port update Message-ID: <1289609730.1517.16.camel@xenon> In-Reply-To: <86k4kim5rl.fsf@gmail.com> References: <AANLkTimouByAhobsa05TCZzM_hoYDmwydnXPmmyQB1vU@mail.gmail.com> <AANLkTik2NZzoX6wFNYsQR6Se0r6i5p0T0%2BifqUZdNeLy@mail.gmail.com> <ibkiq4$bsm$1@lorvorc.mips.inka.de> <86k4kim5rl.fsf@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2010-11-13 at 03:22 +0300, Anonymous wrote:
> Can you try to replace
>
> #ifdef __FreeBSD__
>
> with
>
> #ifdef __FreeBSD__ && __FreeBSD_version >= 800097
>
> Alternatively, just hide the patch under ${OSVERSION} >= 800097.
Just my 2 cents:
Wouldn't be easier to simply made the patch optional via OPTIONS
(defaulting to off) and forget about it?
For example, I too have no use for it, as I don't prefer applications
messing with my mixer and thus run mplayer with -sotfvol. And seriously,
even then, for the past 10 years of pretty heavy mplayer usage - I
changed volume in it for like.. three times, ever (probably by
accident).
So for me, this is a patch that's not part of $Upstream, does absolutely
nothing I need, does even less for 4Front OSS users, and is already
known to break stuff for someone (the last point being somewhat
significant).
Please, don't include it by default for everyone.
m.
--
Michal Varga,
Stonehenge (Gmail account)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1289609730.1517.16.camel>