Date: Tue, 21 May 2013 12:42:00 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Adrian Chadd <adrian@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r250856 - head/sys/dev/ath/ath_hal/ar5416 Message-ID: <20130521164200.GA1643@glenbarber.us> In-Reply-To: <201305211428.r4LES5L8018987@svn.freebsd.org> References: <201305211428.r4LES5L8018987@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 21, 2013 at 02:28:05PM +0000, Adrian Chadd wrote: > Author: adrian > Date: Tue May 21 14:28:05 2013 > New Revision: 250856 > URL: http://svnweb.freebsd.org/changeset/base/250856 >=20 > Log: > Fix build break - the SetCapability calls return HAL_BOOL, > not HAL_STATUS. >=20 > Modified: > head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c >=20 > Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c Tue May 21 13:02:37 201= 3 (r250855) > +++ head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c Tue May 21 14:28:05 201= 3 (r250856) > @@ -504,7 +504,7 @@ ar5416SetCapability(struct ath_hal *ah,=20 > return AH_TRUE; > case HAL_CAP_ENFORCE_TXOP: > if (capability !=3D 1) > - return (HAL_ENOTSUPP); > + return AH_FALSE; > if (setting) { > AH5212(ah)->ah_miscMode > |=3D AR_PCU_TXOP_TBTT_LIMIT_ENA; This breaks tinderbox. /src/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c -I/src/sys/dev/ath -I/src/sys/dev/ath/ath_hal /src/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c:507:12: error: implicit conversion from enumeration type 'HAL_STATUS' to different enumeration type 'HAL_BOOL' [-Werror,-Wenum-conversion] return (HAL_ENOTSUPP); ~~~~~~ ^~~~~~~~~~~~ 1 error generated. *** Error code 1 Stop. make: stopped in /obj/arm.arm/src/sys/LINT Glen --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJRm6PYAAoJEFJPDDeguUajknoIAKoUi5itujDDFqX6gpj2pASm Ktt2DkxQuDndO9oYvbfVhIlvRGOyPqTJQNYXEBGRJ53SlgISiF0/gATeP4rt27x1 XFAmPmlW+ZdW5txyr7oN/cu06AehuxaXeKyhi8jgOF6s7OinBCKnY/2nmAuzBQnF wHTThIraWyTkkiBG6mTCjq8CT66YaQ+F9Pw4wjmFaZ3NFwX9UmzmcX04nZ3QpxNi RsCMZgqDuP7C6RNZsFtCbAOAkeHdev+MALQFx4ks4SQqPudja2dHR0Eqf3pe+5sN wXf26k9Rz4z1LSQhafdO4a8MgHL6jhzobxwjjFurOYmAmwZ8JfytTwyFL0/d9SQ= =j70v -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130521164200.GA1643>