Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Jan 2007 06:16:04 GMT
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 112697 for review
Message-ID:  <200701100616.l0A6G4dV058460@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=112697

Change 112697 by sam@sam_ebb on 2007/01/10 06:15:49

	bandaid problem with probing the initial bss node created
	in adhoc mode; if we send a null data frame w/o any rates
	defined the driver may blow up; this'll get fixed properly
	by setting up a proper initial rate set for the node soon

Affected files ...

.. //depot/projects/wifi/sys/net80211/ieee80211_node.c#75 edit

Differences ...

==== //depot/projects/wifi/sys/net80211/ieee80211_node.c#75 (text+ko) ====

@@ -1471,9 +1471,16 @@
 			 * send a null data frame which may not be
 			 * universally supported by drivers (need it
 			 * for ps-poll support so it should be...).
+			 *
+			 * XXX don't probe the station unless we've
+			 *     received a frame from them (and have
+			 *     some idea of the rates they are capable
+			 *     of); this will get fixed more properly
+			 *     soon with better handling of the rate set.
 			 */
 			if (0 < ni->ni_inact &&
-			    ni->ni_inact <= ic->ic_inact_probe) {
+			    ni->ni_inact <= ic->ic_inact_probe &&
+			    ni->ni_rates.rs_nrates != 0) {
 				IEEE80211_NOTE(ic,
 				    IEEE80211_MSG_INACT | IEEE80211_MSG_NODE,
 				    ni, "%s",



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701100616.l0A6G4dV058460>