Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Sep 2007 11:50:28 +0100
From:      "Doug Rabson" <dfr@rabson.org>
To:        "Attilio Rao" <attilio@FreeBSD.org>, "John Baldwin" <jhb@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/amd64/amd64 local_apic.c src/sys/i386/acpica madt.c src/sys/i386/i386 local_apic.c src/sys/kern subr_smp.c src/sys/sun4v/mdesc mdesc_init.c
Message-ID:  <073501c7ff61$eae2c830$f713c90a@doug01>
References:  <200709112254.l8BMsB7P074637@repoman.freebsd.org> <200709211436.15444.jhb@freebsd.org> <3bbf2fe10709211338j6dbab59am1ad67c86c1a05baa@mail.gmail.com> <200709241147.49288.jhb@freebsd.org> <3bbf2fe10709241025r4e0d25c6x328ac21dc6bc99c@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
From: "Attilio Rao" <attilio@FreeBSD.org>
>> See above.  Are you going to go throw and assign a static order to ever 
>> device
>> driver now just in case the one's registration routine might someday 
>> depend
>> on another?
>
> Yes, and it doesn't sound so unreasonable.

It sounds silly to me. The only ordering requirement for registering drivers 
is that they should be registered before their parent bus is probed. This is 
simply accomplished by registering *all* drivers in one phase and then 
probing the device tree in a subsequent phase. Adding any extra ordering to 
this is pointless.

If two drivers have dependancies that requires them to be registered in a 
specific order, then my first reaction would be that they are doing 
something very wrong indeed. The only thing which changes if two drivers are 
registered in one order or another is the order that they will be offered 
devices during the probe. Drivers that depend on probe ordering with respect 
to other drivers are usually broken.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?073501c7ff61$eae2c830$f713c90a>