Date: Mon, 4 Dec 2006 09:15:29 +0100 (CET) From: Andre Albsmeier <Andre.Albsmeier@siemens.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/106298: [PATCH]: remove misleading line /bin/hostname from sysutils/bsdstats Message-ID: <200612040815.kB48FTwX092513@curry.mchp.siemens.de> Resent-Message-ID: <200612040820.kB48KG28016828@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 106298
>Category: ports
>Synopsis: [PATCH]: remove misleading line /bin/hostname from sysutils/bsdstats
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Dec 04 08:20:11 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Andre Albsmeier
>Release: FreeBSD 5.5-STABLE i386
>Organization:
>Environment:
Machines using sysutils/bsdstats
>Description:
I suggest removing the line which puts the result of /bin/hostname
into the env variable HN. This hostname is never used but people
might get distracted from using bsdstats when checking the code not
close enough. (I wouldn't like to have my hostnames being sent to
the server).
>How-To-Repeat:
grep HN 300.statistics
>Fix:
--- 300.statistics.ORI Mon Dec 4 09:04:34 2006
+++ 300.statistics Mon Dec 4 09:04:44 2006
@@ -397,7 +397,6 @@
case "$monthly_statistics_enable" in
[Yy][Ee][Ss])
check_dns
- HN=`/bin/hostname`
REL=`/usr/bin/uname -r`
ARCH=`/usr/bin/uname -m`
OS=`/usr/bin/uname -s`
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612040815.kB48FTwX092513>