Date: Mon, 19 Sep 2016 14:03:05 -0700 From: Conrad Meyer <cem@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr Message-ID: <CAG6CVpU2cxRHKF72MLu5AH-NvAbOBf0i6ZLzzVyD-U6bdye9=g@mail.gmail.com> In-Reply-To: <E52FB33D-0921-404F-8457-0E2CB957556B@gmail.com> References: <201609192043.u8JKh3jv040006@repo.freebsd.org> <E52FB33D-0921-404F-8457-0E2CB957556B@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
If you re-read the sentences you've pasted carefully, I think you'll find it doesn't actually say that the types or param headers come before other sys/ headers. Just that sys/ headers come before non-sys/ headers. Best, Conrad On Mon, Sep 19, 2016 at 1:45 PM, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer <cem@FreeBSD.org> wrote: > > Author: cem > Date: Mon Sep 19 20:43:03 2016 > New Revision: 305998 > URL: https://svnweb.freebsd.org/changeset/base/305998 > > Log: > Move sys/capsicum.h includes after types.h or param.h > > This is not actually documented or even implied in style(9). Make the > change > to match convention. Someone should document this convention in style(9= ). > > Reported by: jhb > Sponsored by: EMC Dell Isilon > > > Uh=E2=80=A6 yes it clearly states it in style(9). From > https://www.freebsd.org/cgi/man.cgi?query=3Dstyle&sektion=3D9 : > > Kernel include files (i.e. sys/*.h) come first; normally, include > <sys/types.h> OR <sys/param.h>, but not both. <sys/types.h> include= s > <sys/cdefs.h>, and it is okay to depend on that. > > Thanks, > -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpU2cxRHKF72MLu5AH-NvAbOBf0i6ZLzzVyD-U6bdye9=g>