Date: Tue, 21 Jan 2003 11:50:32 +0100 (CET) From: Harti Brandt <brandt@fokus.fraunhofer.de> To: Thomas Moestl <tmm@freebsd.org> Cc: sparc@freebsd.org Subject: Re: Problem with iommu_dvmamap_create Message-ID: <20030121114820.Q80603@beagle.fokus.gmd.de> In-Reply-To: <20030121114313.O80603@beagle.fokus.gmd.de> References: <20030117151958.U715@beagle.fokus.gmd.de> <20030117160857.GB304@crow.dom2ip.de> <20030117171317.F44530@beagle.fokus.gmd.de> <20030117171111.GC304@crow.dom2ip.de> <20030117181111.R45050@beagle.fokus.gmd.de> <20030117173303.GD304@crow.dom2ip.de> <20030120103814.X45050@beagle.fokus.gmd.de> <20030120151712.GA240@crow.dom2ip.de> <20030120161832.K45050@beagle.fokus.gmd.de> <20030120192946.GB240@crow.dom2ip.de> <20030121114313.O80603@beagle.fokus.gmd.de>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-792081354-1043146232=:80603 Content-Type: TEXT/PLAIN; charset=US-ASCII On Tue, 21 Jan 2003, Harti Brandt wrote: HB>With the attached patch it looks better - it removes the check for HB>BUS_DMAMAP_NSEGS and also adds a break for promoting the error from HB>load_buffer back to load_mbuf and exit the loop there in case of an error. HB>(Sorry, the patch contains also the patch that you sent in your last HB>mail). I suppose, that pine might benefit of an option, that checks, that you really have attached something if it finds the word 'attach' in the mail :-) Here is the patch. harti -- harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.gmd.de, brandt@fokus.fhg.de --0-792081354-1043146232=:80603 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="iommu-load.diff" Content-Transfer-Encoding: BASE64 Content-ID: <20030121115032.Q80603@beagle.fokus.gmd.de> Content-Description: Content-Disposition: attachment; filename="iommu-load.diff" SW5kZXg6IGlvbW11LmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBm aWxlOiAvaG9tZS9jdnMvZnJlZWJzZC9zcmMvc3lzL3NwYXJjNjQvc3BhcmM2 NC9pb21tdS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNA0KZGlmZiAt YyAtcjEuMTQgaW9tbXUuYw0KKioqIGlvbW11LmMJNiBKYW4gMjAwMyAyMTo1 OTo1NCAtMDAwMAkxLjE0DQotLS0gaW9tbXUuYwkyMSBKYW4gMjAwMyAxMDo0 MzowMiAtMDAwMA0KKioqKioqKioqKioqKioqDQoqKiogMjg4LDI5MyAqKioq DQotLS0gMjg4LDI5NCAtLS0tDQogIAlzdHJ1Y3QgaW9tbXVfc3RhdGUgKmZp cnN0Ow0KICAJdm1fc2l6ZV90IHNpemU7DQogIAl2bV9vZmZzZXRfdCBvZmZz Ow0KKyAJdV9pbnQ2NF90IGVuZDsNCiAgCWludCBpOw0KICANCiAgCS8qDQoq KioqKioqKioqKioqKioNCioqKiAzMTcsMzI5ICoqKioNCiAgCQkgKiBGaXJz dCBJT01NVSB0byBiZSByZWdpc3RlcmVkOyBzZXQgdXAgcmVzb3VyY2UgbWFt YW5nZW1lbnQNCiAgCQkgKiBhbmQgYWxsb2NhdGUgVFNCIG1lbW9yeS4NCiAg CQkgKi8NCiAgCQlpb21tdV9kdm1hX3JtYW4ucm1fdHlwZSA9IFJNQU5fQVJS QVk7DQogIAkJaW9tbXVfZHZtYV9ybWFuLnJtX2Rlc2NyID0gIkRWTUEgTWVt b3J5IjsNCiAgCQlpZiAocm1hbl9pbml0KCZpb21tdV9kdm1hX3JtYW4pICE9 IDAgfHwNCiAgCQkgICAgcm1hbl9tYW5hZ2VfcmVnaW9uKCZpb21tdV9kdm1h X3JtYW4sDQogIAkJICAgIChpcy0+aXNfZHZtYWJhc2UgPj4gSU9fUEFHRV9T SElGVCkgKyByZXN2cGcsDQohIAkJICAgIChpcy0+aXNfZHZtYWJhc2UgKyAo c2l6ZSA8PA0KISAJCSAgICAgKElPX1BBR0VfU0hJRlQgLSBJT1RURV9TSElG VCkpKSA+PiBJT19QQUdFX1NISUZUKSAhPSAwKQ0KICAJCQlwYW5pYygiaW9t bXVfaW5pdDogY2FuJ3QgaW5pdGlhbGl6ZSBkdm1hIHJtYW4iKTsNCiAgCQkv Kg0KICAJCSAqIEFsbG9jYXRlIG1lbW9yeSBmb3IgSS9PIHBhZ2UgdGFibGVz LiAgVGhleSBuZWVkIHRvIGJlDQotLS0gMzE4LDMzMCAtLS0tDQogIAkJICog Rmlyc3QgSU9NTVUgdG8gYmUgcmVnaXN0ZXJlZDsgc2V0IHVwIHJlc291cmNl IG1hbWFuZ2VtZW50DQogIAkJICogYW5kIGFsbG9jYXRlIFRTQiBtZW1vcnku DQogIAkJICovDQorIAkJZW5kID0gaXMtPmlzX2R2bWFiYXNlICsgKHNpemUg PDwgKElPX1BBR0VfU0hJRlQgLSBJT1RURV9TSElGVCkpOw0KICAJCWlvbW11 X2R2bWFfcm1hbi5ybV90eXBlID0gUk1BTl9BUlJBWTsNCiAgCQlpb21tdV9k dm1hX3JtYW4ucm1fZGVzY3IgPSAiRFZNQSBNZW1vcnkiOw0KICAJCWlmIChy bWFuX2luaXQoJmlvbW11X2R2bWFfcm1hbikgIT0gMCB8fA0KICAJCSAgICBy bWFuX21hbmFnZV9yZWdpb24oJmlvbW11X2R2bWFfcm1hbiwNCiAgCQkgICAg KGlzLT5pc19kdm1hYmFzZSA+PiBJT19QQUdFX1NISUZUKSArIHJlc3ZwZywN CiEgCQkgICAgKGVuZCA+PiBJT19QQUdFX1NISUZUKSAtIDEpICE9IDApDQog IAkJCXBhbmljKCJpb21tdV9pbml0OiBjYW4ndCBpbml0aWFsaXplIGR2bWEg cm1hbiIpOw0KICAJCS8qDQogIAkJICogQWxsb2NhdGUgbWVtb3J5IGZvciBJ L08gcGFnZSB0YWJsZXMuICBUaGV5IG5lZWQgdG8gYmUNCioqKioqKioqKioq KioqKg0KKioqIDgxMSw4MTggKioqKg0KICAJCQkJICAgICJzbWFsbFxuIik7 DQogIAkJCX0NCiAgCQkJc2djbnQrKzsNCiEgCQkJaWYgKHNnY250ID49IGR0 LT5kdF9uc2VnbWVudHMgfHwNCiEgCQkJICAgIHNnY250ID49IEJVU19ETUFN QVBfTlNFR1MpIHsNCiAgCQkJCWVycm9yID0gRUZCSUc7DQogIAkJCQlicmVh azsNCiAgCQkJfQ0KLS0tIDgxMiw4MTggLS0tLQ0KICAJCQkJICAgICJzbWFs bFxuIik7DQogIAkJCX0NCiAgCQkJc2djbnQrKzsNCiEgCQkJaWYgKHNnY250 ID49IGR0LT5kdF9uc2VnbWVudHMpIHsNCiAgCQkJCWVycm9yID0gRUZCSUc7 DQogIAkJCQlicmVhazsNCiAgCQkJfQ0KKioqKioqKioqKioqKioqDQoqKiog ODMyLDgzOCAqKioqDQogIAkJZmlyc3RwZyA9IDA7DQogIAl9DQogIAkqc2Vn cCA9IHNnY250Ow0KISAJcmV0dXJuICgwKTsNCiAgDQogIH0NCiAgDQotLS0g ODMyLDgzOCAtLS0tDQogIAkJZmlyc3RwZyA9IDA7DQogIAl9DQogIAkqc2Vn cCA9IHNnY250Ow0KISAJcmV0dXJuIChlcnJvcik7DQogIA0KICB9DQogIA0K KioqKioqKioqKioqKioqDQoqKiogOTAwLDkwNSAqKioqDQotLS0gOTAwLDkw NyAtLS0tDQogIAkJCQljb250aW51ZTsNCiAgCQkJZXJyb3IgPSBpb21tdV9k dm1hbWFwX2xvYWRfYnVmZmVyKGR0LCBpcywgbWFwLCBzZ3MsDQogIAkJCSAg ICBtLT5tX2RhdGEsIG0tPm1fbGVuLCBOVUxMLCBmbGFncywgJm5zZWdzLCBm aXJzdCk7DQorIAkJCWlmIChlcnJvcikNCisgCQkJCWJyZWFrOw0KICAJCQlm aXJzdCA9IDA7DQogIAkJfQ0KICAJfSBlbHNlDQo= --0-792081354-1043146232=:80603-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-sparc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030121114820.Q80603>