Date: Wed, 29 May 2002 13:33:41 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Matthew Dillon <dillon@apollo.backplane.com>, "David O'Brien" <obrien@FreeBSD.ORG>, John Baldwin <jhb@FreeBSD.ORG>, FreeBSD current users <current@FreeBSD.ORG> Subject: Re: Seeking OK to commit KSE MIII Message-ID: <Pine.BSF.4.21.0205291331010.12315-100000@InterJet.elischer.org> In-Reply-To: <13192.1022704058@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 29 May 2002, Poul-Henning Kamp wrote: > In message <200205292007.g4TK71YD062671@apollo.backplane.com>, Matthew Dillon w > rites: > > > I agree that as a general rule of thumb it makes sense to commit > > whitespace/paren/brace changes separately, but that is ALL it is. > > A rule of thumb. It should not be followed blindly, on principle, > > if it has an adverse effect on the developer tring to do the work, > > and it certainly should not be made a prerequisit for having good > > work comitted. I see no benefit to the project or the developer > > community. > > For complex patches, which should get good and thorough reviews before > they are committed, avoiding unsubstantial style/whitespace changes from > cluttering the patch should be mandatory. > > Julians patch clearly belongs in this category. > > Consequently, it is in Julians own interest to get the whitespace/style > changes into the tree first (they don't need a review, if he does > them right) since that makes the patch people have to read through > correspondingly smaller. Generally I agree with this statement.. in the case of the braces in question, they are part of an if statement that got rewritten so I'm slightly surprised that they are considered "unrelated" to the patch. I'm happy to commit it separatly right nowe though, as it's another 6 line less of diff :-) > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0205291331010.12315-100000>