Date: Tue, 8 Apr 2003 15:35:11 -0700 (PDT) From: Peter Wemm <peter@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 28567 for review Message-ID: <200304082235.h38MZBuh097473@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=28567 Change 28567 by peter@peter_daintree on 2003/04/08 15:34:13 remove damn noisy printf in setidt(). remove tss_rsp1/rsp2 - we dont use ring 1 or 2 anywhere (neither on i386) add comment about missing an update of tss_rsp0 in cpu_switch() Affected files ... .. //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#55 edit Differences ... ==== //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#55 (text+ko) ==== @@ -630,7 +630,6 @@ ip->gd_dpl = SEL_KPL; ip->gd_p = 1; ip->gd_hioffset = ((uintptr_t)func)>>16 ; -printf("setidt: idx:%2d 0x%08x 0x%08x 0x%08x 0x%08x\n", idx, ((u_int32_t *)ip)[0], ((u_int32_t *)ip)[1], ((u_int32_t *)ip)[2], ((u_int32_t *)ip)[3]); } #define IDTVEC(name) __CONCAT(X,name) @@ -1240,8 +1239,7 @@ /* make an initial tss so cpu can get interrupt stack on syscall! */ common_tss.tss.tss_rsp0 = thread0.td_kstack + KSTACK_PAGES * PAGE_SIZE - sizeof(struct pcb); - common_tss.tss.tss_rsp1 = common_tss.tss.tss_rsp0; - common_tss.tss.tss_rsp2 = common_tss.tss.tss_rsp0; + /* XXX we need to update tss_rsp0 in cpu_switch */ /* doublefault stack space, runs on ist1 */ common_tss.tss.tss_ist1 = (long)&dblfault_stack[sizeof(dblfault_stack)];
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200304082235.h38MZBuh097473>