Date: Mon, 26 Jul 2010 14:08:56 +0200 (CEST) From: dirk.meyer@dinoex.sub.org To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/148960: [patch] print/ghostscript8 fails to suppport X Message-ID: <201007261208.o6QC8utZ038426@home3.dinoex.sub.de> Resent-Message-ID: <201007261210.o6QCA5Vh045328@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 148960 >Category: ports >Synopsis: [patch] print/ghostscript8 fails to suppport X >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 26 12:10:04 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Dirk Meyer >Release: FreeBSD 8.1-RELEASE >Organization: privat >Environment: ghostscript8 and ghostview isntalled. >Description: The port does not check the output from "OPTIONS" if the default of that option in "on" http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#AEN2446 The ghostscript8 port has different defaults in "OPTIONS" OPTIONS= FOO "Enable option foo" ${DEFAULT_ON_OFF} in case of default "off" the port check the correctly: .if defined(WITH_FOO) CONFIGURE_ARGS+= .... .else CONFIGURE_ARGS+= .... .endif in case of default "on" the port check the correctly: .if defined(WITHOUT_FOO) CONFIGURE_ARGS+= .... .else CONFIGURE_ARGS+= .... .endif WITH_FOO is not defined! better would be: .if defined(WITH_FOO) || !defined(WITHOUT_FOO) CONFIGURE_ARGS+= .... .else CONFIGURE_ARGS+= .... .endif testcases: 1. default "on", Option selected => WITH_FOO=true 2. default "on", Option deselected => WITHOUT_FOO=true 3. default "off", Option selected => WITH_FOO=true 4. default "off", Option deselected => WITHOUT_FOO=true 5. default "on", BATCH=yes => WITH_FOO=true 5. default "off", BATCH=yes => WITHOUT_FOO=yes, WITH_FOO=true print/ghostscript8-nox11# make BATCH=yes -V WITH_X11 -V WITHOUT_X11 true yes print/ghostscript8# make BATCH=yes -V WITH_X11 -V WITHOUT_X11 true >How-To-Repeat: ghostview fails to display any files, reporting "Unknown device: x11" to confirm ghostscript does not list x11 with: gs -h >Fix: apply the patch to fix most of the problems: Index: files/Makefile.drivers_post =================================================================== RCS file: /home/pcvs/ports/print/ghostscript8/files/Makefile.drivers_post,v retrieving revision 1.2 diff -u -r1.2 Makefile.drivers_post --- files/Makefile.drivers_post 25 May 2010 21:30:43 -0000 1.2 +++ files/Makefile.drivers_post 26 Jul 2010 11:56:33 -0000 @@ -59,10 +59,13 @@ .undef _CUPS_DEVS .for D in ${CUPS_DEVS} -.if defined(WITHOUT_CUPS) +.if defined(WITHOUT_CUPS) || defined(WITHOUT_GS_${D}) .undef WITH_GS_${D} .elif defined(WITH_GS_${D}) _CUPS_DEVS+= ${D} +.elif ${OPTIONS_CUPS_DEFAULT} == "on" +_CUPS_DEVS+= ${D} +WITH_GS_${D}=yes .endif .endfor @@ -78,10 +81,13 @@ .undef _VGA_DEVS .for D in ${VGA_DEVS} -.if defined(WITHOUT_SVGALIB) +.if defined(WITHOUT_SVGALIB) || defined(WITHOUT_GS_${D}) .undef WITH_GS_${D} .elif defined(WITH_GS_${D}) _VGA_DEVS+= ${D} +.elif ${OPTIONS_SVGALIB_DEFAULT} == "on" +_VGA_DEVS+= ${D} +WITH_GS_${D}=yes .endif .endfor @@ -95,10 +101,13 @@ .undef _X11_DEVS .for D in ${X11_DEVS} -.if defined(WITHOUT_X11) +.if defined(WITHOUT_X11) || defined(WITHOUT_GS_${D}) . undef WITH_GS_${D} .elif defined(WITH_GS_${D}) _X11_DEVS+= ${D} +.elif ${OPTIONS_X11_DEFAULT} == "on" +_X11_DEVS+= ${D} +WITH_GS_${D}=yes .endif .endfor @@ -121,10 +130,13 @@ .undef _ICONV_DEVS .for D in ${ICONV_DEVS} -.if defined(WITHOUT_ICONV) +.if defined(WITHOUT_ICONV) || defined(WITHOUT_GS_${D}) .undef WITH_GS_${D} .elif defined(WITH_GS_${D}) _ICONV_DEVS+= ${D} +.elif ${OPTIONS_ICONV_DEFAULT} == "on" +_ICONV_DEVS+= ${D} +WITH_GS_${D}=yes .endif .endfor >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007261208.o6QC8utZ038426>