Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Dec 2002 10:04:42 -0500 (EST)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Maxim Konovalov <maxim@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/netinet ip_dummynet.c
Message-ID:  <Pine.NEB.3.96L.1021215100328.86543C-100000@fledge.watson.org>
In-Reply-To: <200212151021.gBFALV1Y040756@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
I've noticed this in some other places in the code, and was confused about
it myself for a bit.  Part of the problem is that the flags appear to come
from the same namespace.  It should be easy enough to catch this though by
temporarily diverging the values of the flags and making sure there are
asserts in the appropriate calls that consume the flags.  Alternatively,
would could combine the flags... :-)

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories

On Sun, 15 Dec 2002, Maxim Konovalov wrote:

> maxim       2002/12/15 02:21:31 PST
> 
>   Modified files:
>     sys/netinet          ip_dummynet.c 
>   Log:
>   o M_DONTWAIT is mbuf(9) flag: malloc(M_DONTWAIT) -> malloc(M_NOWAIT).
>   The bug does not affect anything because M_NOWAIT == M_DONTWAIT.
>   
>   Reviewed by:    luigi
>   MFC after:      1 week
>   
>   Revision  Changes    Path
>   1.57      +7 -7      src/sys/netinet/ip_dummynet.c
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1021215100328.86543C-100000>